Re: [Buildroot] [PATCH/next v4 1/2] package/onevpl: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Bernd, All,

On 2023-08-08 08:41 +0200, Bernd Kuhls spake thusly:
> From: Bernd Kuhls <bernd.kuhls@t-online.de>
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
[--SNIP--]
> diff --git a/package/onevpl/Config.in b/package/onevpl/Config.in
> new file mode 100644
> index 0000000000..65a34185e3
> --- /dev/null
> +++ b/package/onevpl/Config.in
> @@ -0,0 +1,26 @@
> +config BR2_PACKAGE_ONEVPL_ARCH_SUPPORTS
> +	bool
> +	default y if BR2_ARCH_IS_64
> +	default y if BR2_arm
> +
> +config BR2_PACKAGE_ONEVPL
> +	bool "onevpl"
> +	depends on BR2_PACKAGE_ONEVPL_ARCH_SUPPORTS
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on !BR2_STATIC_LIBS # dlfcn.h
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_WAYLAND_PROTOCOLS if BR2_PACKAGE_WAYLAND
> +	select BR2_PACKAGE_LIBDRM_INTEL if BR2_PACKAGE_LIBVA

This is incorrect, as BR2_PACKAGE_LIBDRM_INTEL needs i386 or x86_64, but
BR2_PACKAGE_ONEVPL_ARCH_SUPPORTS allows any 64-bit arch, like aarch64,
mips64, ppc64...

This is causing build failures, such as:

    http://autobuild.buildroot.org/results/8fa/8fa0f2cd7a027d3d8fae56125621b0b814e132da/

    make: Entering directory '/home/buildroot/autobuild/run/instance-0/buildroot'
    Makefile:576: *** libpciaccess is in the dependency chain of libdrm that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.
    make: Leaving directory '/home/buildroot/autobuild/run/instance-0/buildroot'

Can you look into that, please (note that you renamed the package to
libvpl later, so it would be nice to have a fix for master and one for
the 2023.11.x branch.

Regards,
Yann E. MORIN.

> +	select BR2_PACKAGE_LIBXCB if BR2_PACKAGE_XORG7
> +	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
> +	help
> +	  oneAPI Video Processing Library (oneVPL) dispatcher,
> +	  tools, and examples
> +
> +	  https://github.com/oneapi-src/oneVPL
> +
> +comment "onevpl needs a toolchain w/ dynamic library, gcc >= 7, C++, threads"
> +	depends on BR2_PACKAGE_ONEVPL_ARCH_SUPPORTS
> +	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
> +		!BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/onevpl/onevpl.hash b/package/onevpl/onevpl.hash
> new file mode 100644
> index 0000000000..c9ca1e6c04
> --- /dev/null
> +++ b/package/onevpl/onevpl.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  4411543519486a2450f6f5af06a077596e7888a551768594e9dfa2a46b23b6f5  onevpl-2023.3.1.tar.gz
> +sha256  bf1cfac2e2792b6e1e995ce103d70796aecaf2ec7e4c5fe5474f7acec7b4a677  LICENSE
> diff --git a/package/onevpl/onevpl.mk b/package/onevpl/onevpl.mk
> new file mode 100644
> index 0000000000..2033f755c0
> --- /dev/null
> +++ b/package/onevpl/onevpl.mk
> @@ -0,0 +1,43 @@
> +################################################################################
> +#
> +# onevpl
> +#
> +################################################################################
> +
> +ONEVPL_VERSION = 2023.3.1
> +ONEVPL_SITE = $(call github,oneapi-src,oneVPL,v$(ONEVPL_VERSION))
> +ONEVPL_LICENSE = MIT
> +ONEVPL_LICENSE_FILES = LICENSE
> +ONEVPL_INSTALL_STAGING = YES
> +ONEVPL_DEPENDENCIES = host-pkgconf
> +
> +ONEVPL_CONF_OPTS = \
> +	-DINSTALL_EXAMPLE_CODE=OFF
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +ONEVPL_CONF_OPTS += \
> +	-DCMAKE_CXX_FLAGS="-latomic"
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBVA),y)
> +ONEVPL_CONF_OPTS += -DENABLE_VA=ON
> +ONEVPL_DEPENDENCIES += libva
> +else
> +ONEVPL_CONF_OPTS += -DENABLE_VA=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_WAYLAND),y)
> +ONEVPL_CONF_OPTS += -DENABLE_WAYLAND=ON
> +ONEVPL_DEPENDENCIES += wayland wayland-protocols
> +else
> +ONEVPL_CONF_OPTS += -DENABLE_WAYLAND=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_XORG7),y)
> +ONEVPL_CONF_OPTS += -DENABLE_X11=ON
> +ONEVPL_DEPENDENCIES += libxcb xlib_libX11
> +else
> +ONEVPL_CONF_OPTS += -DENABLE_X11=OFF
> +endif
> +
> +$(eval $(cmake-package))
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot