Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/criu: disable on aarch64_be
Date: Sun, 14 Jan 2024 12:11:01 +0100	[thread overview]
Message-ID: <ZaPBRc4jfREsr0rz@landeda> (raw)
In-Reply-To: <20240114101619.7120-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-01-14 11:16 +0100, Fabrice Fontaine spake thusly:
> armv8a aarch64_be raises the following build failure since the addition
> of the package in commit 3e4b479f39c15ffdf307ec8395d856680c727204:
> 
> Error (compel/arch/aarch64/src/lib/handle-elf-host.c:30): Unsupported Elf format detected
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/8eaa881a926d138a0bfd3f1076246088994e883f
>  - http://autobuild.buildroot.org/results/8de9b4d6b26e06f6b4457a31366bdc0d8a8c34ae
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/criu/Config.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/criu/Config.in b/package/criu/Config.in
> index fc0da823b3..02d000e49b 100644
> --- a/package/criu/Config.in
> +++ b/package/criu/Config.in
> @@ -1,10 +1,10 @@
>  # criu only builds on certain architectures
>  config BR2_PACKAGE_CRIU_ARCH_SUPPORTS
>  	bool
> -	default y if BR2_ARM_CPU_ARMV6
> -	default y if BR2_ARM_CPU_ARMV7A
> -	default y if BR2_ARM_CPU_ARMV7M
> -	default y if BR2_ARM_CPU_ARMV8A
> +	default y if BR2_arm && BR2_ARM_CPU_ARMV6
> +	default y if BR2_arm && BR2_ARM_CPU_ARMV7A
> +	default y if BR2_arm && BR2_ARM_CPU_ARMV7M

armv6 and armv7 can never be aarch64, so there is no need to guard them
with BR2_arm. Also note that this also disables for armeb, not just
aarch64_be.

Unless you meant this commit to mean "disable for armeb and aarch64_be"?

> +	default y if BR2_arm && BR2_ARM_CPU_ARMV8A

This also disables armv8 for armeb. Is that expected?

If it is just about disabling for aarch64_be (and nothing else), then
I'd prefer the condition to be written explicitly, as such:

    default y if BR2_ARM_CPU_ARMV8A && !BR2_aarch64_be

However, if your commit was really about disabling for all big-endian
ARM and Aarch64, then the commit title and commit log should be fixed.

Regards,
Yann E. MORIN.

>  	default y if BR2_aarch64
>  	default y if BR2_x86_64
>  	default y if BR2_powerpc64le # Only support powerpc64 with LE
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-01-14 11:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-14 10:16 [Buildroot] [PATCH 1/1] package/criu: disable on aarch64_be Fabrice Fontaine
2024-01-14 11:11 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaPBRc4jfREsr0rz@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=marcus.folkesson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox