Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Laurent Vivier <laurent@vivier.eu>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build
Date: Sun, 21 Jan 2024 00:13:19 +0100	[thread overview]
Message-ID: <ZaxTjwcOXPHz4LlW@landeda> (raw)
In-Reply-To: <20240120172839.763337-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-01-20 18:28 +0100, Fabrice Fontaine spake thusly:
> Fix the following NLS build failure on musl raised commit
> bf9583a50276f52edbc37d9f85df5f2cc7fdb5dc:
> 
> /home/autobuild/autobuild/instance-4/output-1/host/lib/gcc/mips64el-buildroot-linux-musl/13.2.0/../../../../mips64el-buildroot-linux-musl/bin/ld: discover/pb_discover-pb-discover.o: undefined reference to symbol 'libintl_textdomain'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/6d440d96e811674041b5a1fdae96d4c377824c2a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/petitboot/petitboot.mk | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/package/petitboot/petitboot.mk b/package/petitboot/petitboot.mk
> index c4eb20b44d..2087f01b09 100644
> --- a/package/petitboot/petitboot.mk
> +++ b/package/petitboot/petitboot.mk
> @@ -7,10 +7,18 @@
>  PETITBOOT_VERSION = 1.14
>  PETITBOOT_SOURCE = petitboot-v$(PETITBOOT_VERSION).tar.gz
>  PETITBOOT_SITE = https://github.com/open-power/petitboot/releases/download/v$(PETITBOOT_VERSION)
> -PETITBOOT_DEPENDENCIES = elfutils ncurses udev host-bison host-flex lvm2
> +PETITBOOT_DEPENDENCIES = \
> +	elfutils \
> +	ncurses \
> +	udev \
> +	host-bison \
> +	host-flex \
> +	lvm2 \
> +	$(TARGET_NLS_DEPENDENCIES)
>  PETITBOOT_LICENSE = GPL-2.0
>  PETITBOOT_LICENSE_FILES = COPYING
>  
> +PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)"
>  PETITBOOT_CONF_OPTS = \
>  	--enable-crypt \
>  	--enable-platform-auto \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-01-20 23:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20 17:28 [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build Fabrice Fontaine
2024-01-20 17:37 ` Laurent Vivier
2024-01-20 17:46   ` Fabrice Fontaine
2024-01-20 18:48     ` Laurent Vivier
2024-01-20 23:13 ` Yann E. MORIN [this message]
2024-02-04  9:04 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaxTjwcOXPHz4LlW@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=laurent@vivier.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox