From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/3] package/flutter-pi: remove libgles requirement for gstreamer audio plugin
Date: Tue, 23 Jan 2024 21:36:40 +0100 [thread overview]
Message-ID: <ZbAjWL734XjjiKi1@landeda> (raw)
In-Reply-To: <20240123190035.904936-2-adam.duskett@amarulasolutions.com>
On 2024-01-23 12:00 -0700, Adam Duskett spake thusly:
> package/flutter-pi: remove libgles requirement for gstreamer audio plugin
Duplicate commit title.
> I erroneously added the dependency BR2_PACKAGE_HAS_LIBGLES for the gstreamer
No 'I' in commit logs; instead, we use third-person passive tense. I
reworded the commit log.
> audio player plugin, and the CMakeLists.txt file does not check for gles2 when
> the plugin is selected. This error was likely due to a copy/paste mistake.
> Remove the requirement.
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/flutter-pi/Config.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
> index bb0e3702c1..95b5525806 100644
> --- a/package/flutter-pi/Config.in
> +++ b/package/flutter-pi/Config.in
> @@ -47,7 +47,6 @@ config BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN
>
> config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
> bool "gstreamer audio player"
> - depends on BR2_PACKAGE_HAS_LIBGLES
> select BR2_PACKAGE_GSTREAMER1
> select BR2_PACKAGE_GST1_PLUGINS_BASE
> select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-23 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 19:00 [Buildroot] [PATCH 0/3] flutter-pi audio player plugin Config.in fixes Adam Duskett
2024-01-23 19:00 ` [Buildroot] [PATCH 1/3] package/flutter-pi: remove libgles requirement for gstreamer audio plugin Adam Duskett
2024-01-23 20:36 ` Yann E. MORIN [this message]
2024-02-04 21:32 ` Peter Korsgaard
2024-01-23 19:00 ` [Buildroot] [PATCH 2/3] package/flutter-pi: Fix help text for gstreamer audio player Adam Duskett
2024-01-23 20:37 ` Yann E. MORIN
2024-02-04 21:32 ` Peter Korsgaard
2024-01-23 19:00 ` [Buildroot] [PATCH 3/3] package/flutter-pi: audio player plugin is not compatible with pulseaudio Adam Duskett
2024-01-23 20:47 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbAjWL734XjjiKi1@landeda \
--to=yann.morin.1998@free.fr \
--cc=adam.duskett@amarulasolutions.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox