From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x
Date: Tue, 23 Jan 2024 22:28:03 +0100 [thread overview]
Message-ID: <ZbAvYy3t4myBLwto@landeda> (raw)
In-Reply-To: <20240122223037.889955-1-giulio.benetti@benettiengineering.com>
Giulio, All,
On 2024-01-22 23:30 +0100, Giulio Benetti spake thusly:
> From: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
>
> With gcc version >= 13.x stdint.h must be explicitly included according to
> [0] so add local patch to explicitly include stdint.h.
When I read "local patch", it is not immediately obvious that this is a
backport, or that the patch has been upstreamd, and I am wary of such
situations.
But here, this is an actual backport, so a better phrasing would have
been "so backport a commit that...", which I have done when applying.
> [0]: https://gcc.gnu.org/gcc-13/porting_to.html
>
> Fixes:
> still not happened
>
> Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/uuu/0001-Fix-missing-references.patch | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 package/uuu/0001-Fix-missing-references.patch
>
> diff --git a/package/uuu/0001-Fix-missing-references.patch b/package/uuu/0001-Fix-missing-references.patch
> new file mode 100644
> index 0000000000..140c9755c7
> --- /dev/null
> +++ b/package/uuu/0001-Fix-missing-references.patch
> @@ -0,0 +1,40 @@
> +From 24fd043225903247f71ac10666d820277c0b10b1 Mon Sep 17 00:00:00 2001
> +From: nixgnauhcuy <nixgnauhcuy@gmail.com>
> +Date: Tue, 9 May 2023 14:32:33 +0800
> +Subject: [PATCH] Fix missing references
> +
> +Upstream: https://github.com/nxp-imx/mfgtools/commit/24fd043225903247f71ac10666d820277c0b10b1
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + libuuu/libcomm.h | 1 +
> + uuu/buildincmd.h | 1 +
> + 2 files changed, 2 insertions(+)
> +
> +diff --git a/libuuu/libcomm.h b/libuuu/libcomm.h
> +index 0afdfa3..38d622d 100644
> +--- a/libuuu/libcomm.h
> ++++ b/libuuu/libcomm.h
> +@@ -28,6 +28,7 @@
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + */
> ++#include <stdint.h>
> + #include <string>
> + #include <stdarg.h>
> + #include <locale>
> +diff --git a/uuu/buildincmd.h b/uuu/buildincmd.h
> +index 9415117..46286cc 100644
> +--- a/uuu/buildincmd.h
> ++++ b/uuu/buildincmd.h
> +@@ -31,6 +31,7 @@
> +
> + #pragma once
> +
> ++#include <stdint.h>
> + #include <map>
> + #include <string>
> + #include <vector>
> +--
> +2.34.1
> +
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-23 21:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 22:30 [Buildroot] [PATCH] package/uuu: fix build failure with host gcc 13.x Giulio Benetti
2024-01-23 8:06 ` Dario Binacchi
2024-01-23 21:28 ` Yann E. MORIN [this message]
2024-02-04 21:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbAvYy3t4myBLwto@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=giulio.benetti+tekvox@benettiengineering.com \
--cc=giulio.benetti@benettiengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox