Re: [Buildroot] [PATCH] package/micropython: make use of recent micropython-lib

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Abilio, All,

On 2024-01-28 11:28 -0800, Abilio Marques spake thusly:
> Because this is my first buildroot submission, I tried to keep it simple. It
> makes use of existing micropython tools (used to process manifests) to discover
> the list of packages available in micropython-lib. My hope is that by relying
> on them, any future changes in directory structure will be covered by their own
> "manifestfile.py" tool.

This is a good rationale, and maybe you can add that to the commit log.

> Also, it still copies the files as plain source code ".py" files. I did it this
> way to avoid abrupt changes that could annoy people using the package.

Yes, agreed.

> I have an idea that mixes part of my code (the one that discovers the packages)
> and freezes them (using the same manifests tool), but I thought it would be a
> bridge too far for a successful first submission.

Agreed: I like that your commit does not change the existing behaviour.
This is good.

> Also, I want to find time to
> make it configurable using menuconfig options (each one has it's drawbacks):
> - frozen as mpy files
> - frozen inside the micropython binary
> - keep current text files

We have a similar choice for the full-blown CPython, where we can keep
only .py files, keep only .pyc files, or keep both. So si=uch a choice
for micropython seems totally acceptable. Just o make your future
changes better, it would be two separate changes;
 1. introduce frozen vs. text choice
 2. add frozen-in-binary to the choice

> If there is interest, I can prepare it in a couple weeks from now. Ideas are
> welcomed.

The interest is on your side: if you do not have that interest, do not
do it just for the show; a new feature needs to have someone that
actually needs it and tested it (to some extent).

And speaking of tests, we now have a micropython test:
    support/testing/tests/package/test_micropython.py

So it would be nice that, when/if you add the frozen support, you extend
that test to also test frozen libs.

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot