Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Andreas Naumann <dev@andin.de>
Cc: Bernd Kuhls <bernd@kuhls.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/glm: bump version
Date: Tue, 6 Feb 2024 15:06:16 +0100	[thread overview]
Message-ID: <ZcI82NsG6QZj0L6_@landeda> (raw)
In-Reply-To: <d3a04074-1f6f-4e45-944d-006ec26ab9f3@andin.de>

Andreas, Bernd, All,

On 2024-02-06 14:58 +0100, Andreas Naumann spake thusly:
> Am 14.01.24 um 18:48 schrieb Bernd Kuhls:
> > Fixes build error with packages depending on glm, like kodi-screensaver*
> > and kodi-visualisation*:
> > 
> > CMake Error at /home/buildroot/br2/output/per-package/kodi-screensaver-asteroids/host/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
> >    Could NOT find glm (missing: GLM_INCLUDE_DIR)
> > 
> > Since glm release 0.9.9.8 (bumped in buildroot with commit
> > 01ad11343172ea698e4dcc1c64cb02ce26671e49) many fixes were added for its
> > cmake support: https://github.com/g-truc/glm/pull/1054
> > 
> > Instead of backporting all of them we bump to latest git HEAD.
> > Preparations for glm 1.0.0 are underway:
> > https://github.com/g-truc/glm/pull/1180
> 
> I just now find this patch, after having sent one bumping glm to tag 1.0.0
> (which is only about 2 weeks old). However, since it's a tag, I suggest my
> patch supersedes this one.

Ah, I see you evnetually spotted this patch too! ;-)

I indeed applied your patch, but as I said, I also grabbed the kodi
failures Bernd noticed.

Regards,
Yann E. MORIN.

> regards,
> Andreas
> 
> > 
> > Fixes build error with this defconfig:
> > 
> > BR2_x86_64=y
> > BR2_x86_x86_64_v4=y
> > BR2_BINUTILS_VERSION_2_41_X=y
> > BR2_GCC_VERSION_13_X=y
> > BR2_TOOLCHAIN_BUILDROOT_CXX=y
> > BR2_PER_PACKAGE_DIRECTORIES=y
> > BR2_INIT_NONE=y
> > BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
> > BR2_PACKAGE_KODI=y
> > BR2_PACKAGE_KODI_SCREENSAVER_ASTEROIDS=y
> > BR2_PACKAGE_MESA3D=y
> > BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_IRIS=y
> > BR2_PACKAGE_MESA3D_OPENGL_EGL=y
> > BR2_PACKAGE_MESA3D_OPENGL_ES=y
> > BR2_PACKAGE_PYTHON3=y
> > BR2_PACKAGE_PYTHON3_PY_ONLY=y
> > 
> > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> > ---
> >   package/glm/glm.hash | 2 +-
> >   package/glm/glm.mk   | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/package/glm/glm.hash b/package/glm/glm.hash
> > index c4e2101604..6bc88739b3 100644
> > --- a/package/glm/glm.hash
> > +++ b/package/glm/glm.hash
> > @@ -1,3 +1,3 @@
> >   # Locally calculated
> > -sha256  7d508ab72cb5d43227a3711420f06ff99b0a0cb63ee2f93631b162bfe1fe9592  glm-0.9.9.8.tar.gz
> > +sha256  9dc8c27c2b00d44a0b9d4a619b13848f1092914e7ec60447ac3db528a8e9ba8a  glm-b06b775c1c80af51a1183c0e167f9de3b2351a79.tar.gz
> >   sha256  62d2d642c7d054d4fb4c9b42faad617d6c88fcd91e317f8035aa9f277cc159c3  copying.txt
> > diff --git a/package/glm/glm.mk b/package/glm/glm.mk
> > index ef549931f6..92357b4fe2 100644
> > --- a/package/glm/glm.mk
> > +++ b/package/glm/glm.mk
> > @@ -4,7 +4,7 @@
> >   #
> >   ################################################################################
> > -GLM_VERSION = 0.9.9.8
> > +GLM_VERSION = b06b775c1c80af51a1183c0e167f9de3b2351a79
> >   GLM_SITE = $(call github,g-truc,glm,$(GLM_VERSION))
> >   GLM_LICENSE = MIT
> >   GLM_LICENSE_FILES = copying.txt
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-02-06 14:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-14 17:48 [Buildroot] [PATCH 1/2] package/kodi: needs host-cmake >= 3.26 Bernd Kuhls
2024-01-14 17:48 ` [Buildroot] [PATCH 2/2] package/glm: bump version Bernd Kuhls
2024-02-06 13:58   ` Andreas Naumann
2024-02-06 14:06     ` Yann E. MORIN [this message]
2024-02-06 14:17 ` [Buildroot] [PATCH 1/2] package/kodi: needs host-cmake >= 3.26 Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcI82NsG6QZj0L6_@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=bernd@kuhls.net \
    --cc=buildroot@buildroot.org \
    --cc=dev@andin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox