Re: [Buildroot] [PATCH 1/1] package/python-rpds-py: bump to version 0.16.2

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Antoine, All,

On 2024-02-06 15:09 +0100, Antoine Coutant spake thusly:
> On 11/01/2024 06:17, James Hilliard wrote:
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
[--SNIP--]
> > -PYTHON_RPDS_PY_VERSION = 0.12.0
> > +PYTHON_RPDS_PY_VERSION = 0.16.2
> rpds depends on the crate pyo3. This crate uses
> "std::sync::atomic::AtomicI64" which doesn't exist for 32 bits
> targets. That leads to an error [1].

I have been discussing this with Romain IRL, and he explained that the
issue _already_ happenned with 0.12.0, so this is not a regression and
thus reverting this patch will not fix the issue.

Is that correct?

Also, will std::sync::atomic::AtomicI64 ever be available for 32-bit
targets? If not, would that be considered a bug in the std lib?

> An issue have been opened on pyo3's github [2]. A fix have been accepted [3]
> but it isn't in the last release. Thus, this version bump doesn't
> fix this problem.
> [1]: https://gitlab.com/buildroot.org/buildroot/-/jobs/6093854842
> [2]: https://github.com/PyO3/pyo3/issues/3614
> [3]: https://github.com/PyO3/pyo3/pull/3619

It is not going to be easy to carry this change as a patch in Buildroot:
it would require that we be able to patch a package during the vendoring
step.

In this case, we'd need to do the vendoring (because we need the pyo3
crate to be downloaded), then apply the patch (with mangled paths) to
add the new dependency, then restart the vendoring. In the generic case,
we'd even need to be able to repeat the process in case that new
dependency has to be patched and so on and so on... That's not going to
be easy, by far...

Meh...

We can't even update to a random sha1 from the rpds git tree, because
they do nit even have an update to switch to a newer (even if
unreleased) pyo3.

Meh, again...

Not sure what to do...

What about adding a dependency on BR2_ARCH_IS_64 to python-rpds-pym and
propagate that to all its dependencies?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot