Re: [Buildroot] [RFC PATCH] docs/website: Add Makefile to pre-generate the website

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Ismael Luceno <ismael@iodev.co.uk>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC PATCH] docs/website: Add Makefile to pre-generate the website
Date: Tue, 6 Feb 2024 17:30:37 +0100	[thread overview]
Message-ID: <ZcJerQV0cR4EccKi@landeda> (raw)
In-Reply-To: <ZcJOjrDfe79fPfpz@pirotess>

Ismael, All,

On 2024-02-06 16:21 +0100, Ismael Luceno spake thusly:
> On 06/Feb/2024 16:08, Yann E. MORIN wrote:
[--SNIP--]
> > > +SRCDIR := ${CURDIR}
> > Use parentheses not curly braces, to expand variables in Makefiles,
> > like we do everyelse in Buildroot: $(..)
> > 
> > (yes, both are valid, but lets be consistent throughout our code base)
> OK, I'll change it for v3. I mentioned this before, according to
> both GNU and BSD this is legacy syntax, and new stuff should use
> curly braces...

There is no such deprecation in POSIX:
    https://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html

> > What is the rationale for using smu and tidy to do the deployement?
> > We don't need/want to minimify the content...
> smu is for having some markup support, not used for .html files; as
> for tidy, it just normalises the html indentation, no minification is
> going on.

As we discussed IRL, there is no reason to run smu, as we have no markup
currently; if we want to add markup in the future, then will be the
moment to add the processing, not now. Ditto, cleanup the files with
tidy, if that is even needed, should be done as a linter step to fixup
the files in the tree, not at deployment time.

> > [0] In case of error, we do want to exit in error and be sure this is
> > caught at the Makefile level; by using gawk, you can call:
> >     exit 42
> That also works with any other AWK.

Ah, right:
    https://pubs.opengroup.org/onlinepubs/9699919799/utilities/awk.html

There is however no requirement on any awk implementation for Buildroot,
then just default to: AWK=awk

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot