Re: [Buildroot] [PATCH 1/1] package/dos2unix: bump version to 7.5.2

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Kadambini Nema <kadambini.nema@gmail.com>
Cc: David Bachelart <david.bachelart@bbright.com>,
	Bernd Kuhls <bernd@kuhls.net>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/dos2unix: bump version to 7.5.2
Date: Sun, 18 Feb 2024 22:31:44 +0100	[thread overview]
Message-ID: <ZdJ3QFhBszqQ6cem@landeda> (raw)
In-Reply-To: <20240218061652.1048008-1-kadambini.nema@gmail.com>

Kadambini, All,

On 2024-02-17 22:16 -0800, Kadambini Nema spake thusly:
> Changelog: https://waterlan.home.xs4all.nl/dos2unix/ChangeLog.txt
> 
> $ ./utils/test-pkg -d br_test -k -c  dos2unix.config -p dos2unix
>                     bootlin-armv5-uclibc [1/6]: OK
>                      bootlin-armv7-glibc [2/6]: OK
>                    bootlin-armv7m-uclibc [3/6]: OK
>                      bootlin-x86-64-musl [4/6]: OK
>                       br-arm-full-static [5/6]: OK
>                             sourcery-arm [6/6]: OK
> 6 builds, 0 skipped, 0 build failed, 0 legal-info failed, 0 show-info failed

Thanks for reporting the test you run, that's good thing. However, they
do not belong to the commit log, but to a post-commit note, i.e. [0]

> Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
> ---

[0] here, after the --- line.

>  package/dos2unix/dos2unix.hash | 6 +++---
>  package/dos2unix/dos2unix.mk   | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/dos2unix/dos2unix.hash b/package/dos2unix/dos2unix.hash
> index 032c8ea2d2..d4d682cd0c 100644
> --- a/package/dos2unix/dos2unix.hash
> +++ b/package/dos2unix/dos2unix.hash
> @@ -1,4 +1,4 @@
>  # Locally calculated after checking pgp signature
> -# https://waterlan.home.xs4all.nl/dos2unix/dos2unix-7.5.0.tar.gz.asc
> -sha256  7a3b01d01e214d62c2b3e04c3a92e0ddc728a385566e4c0356efa66fd6eb95af  dos2unix-7.5.0.tar.gz
> -sha256  6009a35c7aaee9888fd4844972c37b84bce22e7407893727c70f4f3560ae3eac  COPYING.txt
> +# https://waterlan.home.xs4all.nl/dos2unix/dos2unix-7.5.2.tar.gz.asc
> +sha256  264742446608442eb48f96c20af6da303cb3a92b364e72cb7e24f88239c4bf3a  dos2unix-7.5.2.tar.gz
> +sha256  03b60fa2cf28b2c6dd585a13b32377c1f87b8f016db44ce2ab6bc7eb306220e2  COPYING.txt

We track the hash of the license files, because we want to know when the
licensing terms change. So, a change in the hash of the license files
must be explained in the commit log. Sometimes, it's just about achange
in years; in such a case, the commit log would just need a note like:
    Copyright years updated in license file.

Can you check that part, and respin, please?

Regards,
Yann E. MORIN.

> diff --git a/package/dos2unix/dos2unix.mk b/package/dos2unix/dos2unix.mk
> index 6d1e70cf26..e30fc999d4 100644
> --- a/package/dos2unix/dos2unix.mk
> +++ b/package/dos2unix/dos2unix.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -DOS2UNIX_VERSION = 7.5.0
> +DOS2UNIX_VERSION = 7.5.2
>  DOS2UNIX_SITE = http://waterlan.home.xs4all.nl/dos2unix
>  DOS2UNIX_LICENSE = BSD-2-Clause
>  DOS2UNIX_LICENSE_FILES = COPYING.txt
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot