From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Nuno Gonçalves" <nunog@fr24.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/google-breakpad: fix tools option identation in menuconfig
Date: Sun, 18 Feb 2024 20:50:29 +0100 [thread overview]
Message-ID: <ZdJfha-psWo-bUZk@landeda> (raw)
In-Reply-To: <20240218193112.1048370-1-nunog@fr24.com>
Nuno, All,
On 2024-02-18 19:30 +0000, Nuno Gonçalves via buildroot spake thusly:
> Move comment in Config.in to end of file so that
> BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS is properly idented.
Ah yes, it was bothering me the other day, but I did not get to it...
> Signed-off-by: Nuno Gonçalves <nunog@fr24.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/google-breakpad/Config.in | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
> index 0d21fd2e5c..5c7f4bb7ba 100644
> --- a/package/google-breakpad/Config.in
> +++ b/package/google-breakpad/Config.in
> @@ -35,14 +35,6 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
>
> https://chromium.googlesource.com/breakpad/breakpad
>
> -comment "google-breakpad requires a glibc toolchain w/ wchar, thread, C++, gcc >= 4.8"
> - depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> - depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> - !BR2_TOOLCHAIN_HAS_THREADS || \
> - !BR2_TOOLCHAIN_USES_GLIBC || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> -
> if BR2_PACKAGE_GOOGLE_BREAKPAD
>
> config BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS
> @@ -52,3 +44,11 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_TOOLS
> minidump_stackwalk and microdump_stackwalk.
>
> endif
> +
> +comment "google-breakpad requires a glibc toolchain w/ wchar, thread, C++, gcc >= 4.8"
> + depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> + depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> + !BR2_TOOLCHAIN_HAS_THREADS || \
> + !BR2_TOOLCHAIN_USES_GLIBC || \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> --
> 2.43.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-02-18 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 19:30 [Buildroot] [PATCH] package/google-breakpad: fix tools option identation in menuconfig Nuno Gonçalves via buildroot
2024-02-18 19:50 ` Yann E. MORIN [this message]
2024-03-16 21:21 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdJfha-psWo-bUZk@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=nunog@fr24.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox