Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Marcus Hoffmann <buildroot@bubu1.eu>
Cc: Norbert Lange <nolange79@gmail.com>,
	Sen Hastings <sen@hastings.org>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/systemd: needs sulogin for emergency target support
Date: Mon, 19 Feb 2024 22:06:19 +0100	[thread overview]
Message-ID: <ZdPCywv45MguAp0g@landeda> (raw)
In-Reply-To: <20240219183828.1289275-1-buildroot@bubu1.eu>

Marcus, All,

On 2024-02-19 19:38 +0100, Marcus Hoffmann via buildroot spake thusly:
> systemd invokes util-linux' sulogin via systemd-sulogin-shell[1] via
> emergency.service/emergency.target[2].
> 
> [1] https://github.com/systemd/systemd/blob/main/src/sulogin-shell/sulogin-shell.c
> [2] https://github.com/systemd/systemd/blob/main/units/emergency.service.in#L23

I thinks that, technically, it could be content with sulogin from
busybox, but since we already select a lot of util-linux' tools, adding
sulogin is not goign to add much to the target size.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
> ---
>  package/systemd/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index 859332d9e4..58b4e51c6d 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -34,6 +34,7 @@ menuconfig BR2_PACKAGE_SYSTEMD
>  	select BR2_PACKAGE_UTIL_LINUX_AGETTY
>  	select BR2_PACKAGE_UTIL_LINUX_MOUNT
>  	select BR2_PACKAGE_UTIL_LINUX_FSCK
> +	select BR2_PACKAGE_UTIL_LINUX_SULOGIN # emergency target
>  	select BR2_PACKAGE_KMOD
>  	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools
>  	select BR2_PACKAGE_KMOD_TOOLS
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-02-19 21:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 18:38 [Buildroot] [PATCH] package/systemd: needs sulogin for emergency target support Marcus Hoffmann via buildroot
2024-02-19 21:06 ` Yann E. MORIN [this message]
2024-03-16 21:25 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdPCywv45MguAp0g@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@bubu1.eu \
    --cc=buildroot@buildroot.org \
    --cc=nolange79@gmail.com \
    --cc=sen@hastings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox