Re: [Buildroot] [PATCH 1/2] package/rust: use host libraries from HOST_DIR

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Romain, All,

On 2024-02-29 14:43 +0100, Romain Naour spake thusly:
> Le 29/02/2024 à 14:35, yann.morin@orange.com a écrit :
> > On 2024-02-29 14:11 +0100, Romain Naour spake thusly:
> >> host-rust package depends on several host packages to provide tools and
> >> libraries but it doesn't take into account HOST_DIR while building rustc
> >> compiler. Indeed, rustc needs zlib and fail to link if zlib is not
> >> installed on the host.
[--SNIP--]
> > But then, we would also need to add host-zlib to
> > HOST_RUST_DEPENDENCIES, no?
> Indeed but in practice host-zlib is already an "indirect" dependency of
> host-rust due to host-openssl (host-libopenssl) dependency.

When a package has a dependency on a library for itself, we must add an
explicit dependency in that package, even if it is transitively brought
by another, like is the case here. So we do want that host-rust depends
on host-zlib explicitly.

>   HOST_LIBOPENSSL_DEPENDENCIES = host-zlib
> 
> I noticed the missing dependency but forgot to add it in HOST_RUST_DEPENDENCIES.

Mark this patch as Changes-requested, then! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot