Re: [Buildroot] [PATCH] package/sbase: new package

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Brian Mayer <bleemayer@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/sbase: new package
Date: Mon, 25 Mar 2024 22:45:20 +0100	[thread overview]
Message-ID: <ZgHwcNeIZdSD19Lz@landeda> (raw)
In-Reply-To: <CAB3eKoABoAsDrsdRZq8uCoxu3uExOMiAY9KsUBYGxoFD_nE-=Q@mail.gmail.com>

Brian, All,

On 2024-03-25 17:10 -0300, Brian Mayer spake thusly:
> sbase is a collection of unix tools that are inherently portable across
> UNIX and UNIX-like systems.
> 
> Signed-off-by: brian <git@myr.sh>

It seems something got slightly wrong when you sent the patch:
  - there was a first one with just the change to package/Config.in
  - then there was one with everything, but it got line-wrapped (see
    below)

This made patchwork miss the second one entirely:
    https://patchwork.ozlabs.org/project/buildroot/patch/CAB3eKoAXBR9MSf1od3mqBnaBV1+xD8BYegFkRQo31UDSx0JQZw@mail.gmail.com/

[--SNIP--]
> diff --git a/package/sbase/Config.in b/package/sbase/Config.in
> new file mode 100644
> index 0000000000..b6ef049b11
> --- /dev/null
> +++ b/package/sbase/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_SBASE
> +        bool "sbase"
> +        help
> +          sbase is a collection of unix tools that are inherently
> portable across
> +         UNIX and UNIX-like systems.
> +
> +         The complement of sbase is ubase[1] which is Linux-specific
> and provides

The lines have been line-wrapped. To avoid that, use 'git send-email'
which properly formats a patch for sending.

Also, it seems they were too long anywat. Please run:

    ./utils/docker-run make check-package

to validate asic coding style rules.

> +         all the non-portable tools. Together they are intended to form a base
> +         system similar to busybox but much smaller and suckless.
> +
> +          https://git.suckless.org/sbase/
> diff --git a/package/sbase/sbase.hash b/package/sbase/sbase.hash
> new file mode 100644
> index 0000000000..d13f3bd110
> --- /dev/null
> +++ b/package/sbase/sbase.hash
> @@ -0,0 +1 @@
> +sha256  af10b9995526b6367e6e11453f4762e4c67d2835ecba7257716b5024440e6f51
>  sbase-13898fa7a91155a60c4c0bd61d4b7693a2ff3f09-br1.tar.gz

Ditto, line-wrapped...

Regards,
Yann E. MORIN.

> diff --git a/package/sbase/sbase.mk b/package/sbase/sbase.mk
> new file mode 100644
> index 0000000000..373ec4965b
> --- /dev/null
> +++ b/package/sbase/sbase.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# sbase
> +#
> +################################################################################
> +
> +SBASE_VERSION = 13898fa7a91155a60c4c0bd61d4b7693a2ff3f09
> +SBASE_SITE = git://git.suckless.org/sbase
> +SBASE_SITE_METHOD = git
> +SBASE_LICENSE = MIT
> +SBASE_LICENSE_FILES = LICENSE README
> +SBASE_CPE_ID_VENDOR = sbase
> +
> +define SBASE_BUILD_CMDS
> +       $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
> +endef
> +
> +define SBASE_INSTALL_TARGET_CMDS
> +       $(MAKE) PREFIX=/usr DESTDIR=$(TARGET_DIR) -C $(@D) install
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.44.0
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot