Re: [Buildroot] [PATCH 05/18] package/kodi: bump version to 21.0-Omega

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Berdn, All,

On 2024-04-06 09:32 +0200, Bernd Kuhls spake thusly:
> Added new dependency to libdisplay-info for gbm support:
> https://github.com/xbmc/xbmc/commit/ce9626479c1792210c7b7cc02c7dc4f819ace509
> 
> Added new required dependency to tinyxml2:
> https://github.com/xbmc/xbmc/commit/9e983ed0449aaf3007d8bfa3261056b120d84188

So, is the dependency to tinyxml still needed?

> Added new required dependency to libudfread: Since upstream commit
> https://github.com/xbmc/xbmc/commit/5f9b9cfa26f274e381e92d73cfa33fb55582436e
> kodi does not build anymore without libudfread.
> 
> Upstream removed the bundled groovy/apache commons binaries:
> https://github.com/xbmc/xbmc/commit/d6bc920e056baad7782f47b86cba85d1336bb134

Any reason why we can't make those additional host packages, e.g. like
add host-groovy, and then use the new -D options listed int hat commit,
to point kodi where they are installed in?

Also, I see you use sha256 hashes for those, but kodi uses sha512
hashes, so I think it would be better to use the same hashes as kodi, so
that we can check that indeed what we get is what kodi expects.

> - JsonSchemaBuilder fixes:
> 
> Upstream moved CMakeLists.txt to src/ subfolder:
> https://github.com/xbmc/xbmc/commit/7e87d98ca55c72fcbc9b8dadf2cb979a85732606
> 
> - TexturePacker fixes:
> 
> texturepacker now depends on c++17:
> https://github.com/xbmc/xbmc/commit/54bd6d7ab552a4ddc04d2595826457d8bfa864d5
> 
> Upstream moved CMakeLists.txt to src/ subfolder
> https://github.com/xbmc/xbmc/commit/e336a75f42d9c4efd3433f3fa6edd05309689deb
> 
> Due to this update we can remove all of our patches for texturepacker.
> 
> Set KODI_SOURCE_DIR variable to root directory of the source tarball,
> LibreELEC added something similar:
> https://github.com/LibreELEC/LibreELEC.tv/commit/70abdd27a22b22547060fcb00a2c70ea61721465

Stating "others do that as well" is not really a justification, although
it can hints that's the way to go.

In fact, the reason is simple: when building natively, outside of a meta
buildsystem like Buildroot, kodi builds its own tools as part of its
build process. TexturePacker needs cmake modules available from the top
of the Kopdi source tree, a source file in a sub-directory at the
top-level source tree, which itself needs includes from the same
sub-dir. The Kodi build process sets KODI_SOURCE_DIR so that
TexturePacker can fidn those files.

In Buildroot, as we cross-build, we build the tools explicitly, without
using the Kodi build process, and thus we must set that variable.

[--SNIP--]
> diff --git a/package/kodi/Config.in b/package/kodi/Config.in
> index 8ad9fdae78..885550a542 100644
> --- a/package/kodi/Config.in
> +++ b/package/kodi/Config.in
[--SNIP--]
> @@ -56,6 +57,7 @@ menuconfig BR2_PACKAGE_KODI
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libass -> harfbuzz
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9 # C++17
> +	depends on BR2_HOST_GCC_AT_LEAST_9 # C++17

It's not Kodi itself that needs host C++17, it's host-kodi-texturepacker
so the dependency needs to reflect that:

    depends on BR2_HOST_GCC_AT_LEAST_9  # host-kodi-texturepacker

(unless kodi itself needs it during its own build, of course, at which
point you'll need to expalin so in the commit log as well.)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot