Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/quagga: add libxcrypt optional dependency
Date: Sun, 7 Apr 2024 14:19:14 +0200	[thread overview]
Message-ID: <ZhKPQg5bfmEpx0Ji@landeda> (raw)
In-Reply-To: <20240407100012.595352-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-04-07 12:00 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since bump of glibc to version
> 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97:
> 
> /home/autobuild/autobuild/instance-5/output-1/host/lib/gcc/nios2-buildroot-linux-gnu/12.3.0/../../../../nios2-buildroot-linux-gnu/bin/ld: ../lib/.libs/libzebra.so: undefined reference to `crypt'
> 
> Fixes: b5680f53d60acf8ff6010082f873438a39bd5d97
>  - http://autobuild.buildroot.org/results/984572031cedd124f48b5a5bc5abe6096d22eaf3
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/quagga/Config.in | 1 +
>  package/quagga/quagga.mk | 4 ++++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/package/quagga/Config.in b/package/quagga/Config.in
> index 9427475d03..9361b6a212 100644
> --- a/package/quagga/Config.in
> +++ b/package/quagga/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_QUAGGA
>  	bool "quagga"
>  	depends on BR2_USE_MMU # fork()
> +	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
>  	help
>  	  Routing software suite, providing implementations of OSPFv2,
>  	  OSPFv3 (IPv6), RIP v1 and v2, RIPng (IPv6) and BGPv4+.
> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
> index 97297baff8..5d8d52263a 100644
> --- a/package/quagga/quagga.mk
> +++ b/package/quagga/quagga.mk
> @@ -33,6 +33,10 @@ else
>  QUAGGA_CONF_OPTS += --disable-capabilities
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)
> +QUAGGA_DEPENDENCIES += libxcrypt
> +endif
> +
>  ifeq ($(BR2_PACKAGE_PROTOBUF_C),y)
>  QUAGGA_CONF_OPTS += --enable-protobuf
>  QUAGGA_DEPENDENCIES += protobuf-c
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-04-07 12:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07 10:00 [Buildroot] [PATCH 1/1] package/quagga: add libxcrypt optional dependency Fabrice Fontaine
2024-04-07 12:19 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhKPQg5bfmEpx0Ji@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox