Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Alessandro Partesotti <a.partesotti@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/oatpp: disable tests
Date: Sun, 7 Apr 2024 17:47:45 +0200	[thread overview]
Message-ID: <ZhLAIYOTYcgk-cUK@landeda> (raw)
In-Reply-To: <20240407135951.1868714-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-04-07 15:59 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since the addition of the package
> in commit d5bba26801b352f591451cf73e0b7509de0e6850:
> 
> [100%] Linking CXX executable oatppAllTests
> /home/buildroot/instance-0/output-1/per-package/oatpp/host/opt/ext-toolchain/m68k-buildroot-uclinux-uclibc/bin/ld.real: cannot find -latomic: No such file or directory
> 
> Fixes: d5bba26801b352f591451cf73e0b7509de0e6850
>  - http://autobuild.buildroot.org/results/1587b391baecdbb5a24a0c0b2c33d63cb71a2f7f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

I guess we'll leave it to users of oatpp, of which we have none in
Buildroot, to properly link with the required libraries, then...

Regards,
Yann E. MORIN.

> ---
>  package/oatpp/oatpp.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk
> index c8b0c9694a..d3f6e1a9c2 100644
> --- a/package/oatpp/oatpp.mk
> +++ b/package/oatpp/oatpp.mk
> @@ -8,7 +8,7 @@ OATPP_VERSION = 1.3.0
>  OATPP_SITE = $(call github,oatpp,oatpp,$(OATPP_VERSION))
>  OATPP_LICENSE = Apache-2.0
>  OATPP_LICENSE_FILES = LICENSE
> -OATPP_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF
> +OATPP_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF -DOATPP_BUILD_TESTS=OFF
>  OATPP_INSTALL_STAGING = YES
>  # Only builds a static lib and headers
>  OATPP_INSTALL_TARGET = NO
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-04-07 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07 13:59 [Buildroot] [PATCH 1/1] package/oatpp: disable tests Fabrice Fontaine
2024-04-07 15:47 ` Yann E. MORIN [this message]
2024-05-02 11:29 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhLAIYOTYcgk-cUK@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=a.partesotti@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox