From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] toolchain/external: remove libcrypt from glibc
Date: Tue, 9 Apr 2024 22:35:37 +0200 [thread overview]
Message-ID: <ZhWmmaKyYDHbqNQA@landeda> (raw)
In-Reply-To: <20240409215100.7440fd16@windsurf>
Thomas, All,
On 2024-04-09 21:51 +0200, Thomas Petazzoni spake thusly:
> On Mon, 8 Apr 2024 22:57:42 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > Note: this commit only deals with glibc and its internal libcrypt (or
> > lack thereof); other C libraries, musl and uClibc-NG, are not considered.
[--SNIP--]
> > ifeq ($(BR2_TOOLCHAIN_EXTERNAL_GLIBC),y)
> > TOOLCHAIN_EXTERNAL_LIBS += libnss_files.so.* libnss_dns.so.* libmvec.so.* libanl.so.*
> > +# Note: explicitly do copy libcrypt*.so.* even for glibc: it is not the same
> Are you sure you wanted to say libcrypt*.so.* here? Didn't you want to
> say libcrypt.so.1 ?
Damned, I missed that. Yes, this is about "libcrypt.so.1" explicitly.
> If you wanted to say libcrypt.so.1, then the patch is fine for me and
> you can add my
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Good, I'll respin.
Regards,
Yann E. MORIN.
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-04-09 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 20:57 [Buildroot] [PATCH] toolchain/external: remove libcrypt from glibc Yann E. MORIN
2024-04-09 19:51 ` Thomas Petazzoni via buildroot
2024-04-09 20:35 ` Yann E. MORIN [this message]
2024-04-09 21:56 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhWmmaKyYDHbqNQA@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox