From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Ben Hutchings <ben.hutchings@mind.be>
Cc: oss-security@lists.openwall.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/skeleton-init-sysv: Set sticky bit on /dev/shm
Date: Thu, 11 Apr 2024 20:31:42 +0200 [thread overview]
Message-ID: <ZhgsjkTpLfChnX_U@landeda> (raw)
In-Reply-To: <20240411152016.1185109-1-ben.hutchings@mind.be>
Ben, All,
On 2024-04-11 17:20 +0200, Ben Hutchings via buildroot spake thusly:
> /dev/shm is a world-writable directory, like /tmp, and should also
> have the sticky bit set. Without this, any user can delete and
> replace another user's files in /dev/shm.
Indeed, good catch!
> This bug has been present since /dev/shm was added to the skeleton
> /etc/fstab, but appears to have been fixed for systems using systemd
> by commit 76fc9275f14e "system: separate sysv and systemd parts of the
> skeleton" which went into Buildroot 2017.08.
>
> Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>
> Fixes: 22fde22e35f98f7830c2f8955465532328348cd1
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/skeleton-init-sysv/skeleton/etc/fstab | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/skeleton-init-sysv/skeleton/etc/fstab b/package/skeleton-init-sysv/skeleton/etc/fstab
> index 169054b74f..06c20fe9d5 100644
> --- a/package/skeleton-init-sysv/skeleton/etc/fstab
> +++ b/package/skeleton-init-sysv/skeleton/etc/fstab
> @@ -2,7 +2,7 @@
> /dev/root / ext2 rw,noauto 0 1
> proc /proc proc defaults 0 0
> devpts /dev/pts devpts defaults,gid=5,mode=620,ptmxmode=0666 0 0
> -tmpfs /dev/shm tmpfs mode=0777 0 0
> +tmpfs /dev/shm tmpfs mode=1777 0 0
> tmpfs /tmp tmpfs mode=1777 0 0
> tmpfs /run tmpfs mode=0755,nosuid,nodev 0 0
> sysfs /sys sysfs defaults 0 0
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-04-11 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 15:20 [Buildroot] [PATCH] package/skeleton-init-sysv: Set sticky bit on /dev/shm Ben Hutchings via buildroot
2024-04-11 18:31 ` Yann E. MORIN [this message]
[not found] ` <ZhgCNMQXfxPXuqvs@cephalopod>
2024-05-06 10:24 ` [Buildroot] Buildroot: incorrect permissons " Ben Hutchings via buildroot
2024-05-06 18:32 ` Yann E. MORIN
2024-05-07 9:10 ` Peter Korsgaard
2024-05-06 21:04 ` [Buildroot] [PATCH] package/skeleton-init-sysv: Set sticky bit " Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhgsjkTpLfChnX_U@landeda \
--to=yann.morin.1998@free.fr \
--cc=ben.hutchings@mind.be \
--cc=buildroot@buildroot.org \
--cc=oss-security@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox