Re: [Buildroot] [PATCH v2 1/3] package/uclibc: Bump to 1.0.48.

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Dimitry, All,

Thanks for working on this version bump! :-)

When resending a patch in a series, resend the full series, not just the
fixed patch.

Also...

On 2024-05-01 12:37 +0300, Dmitry Chestnykh spake thusly:
> In 1.0.48 release uClibc-ng has provided the fix
> for SPARC related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784
> 
> Signed-off-by: Dmitry Chestnykh <dm.chestnykh@gmail.com>
> ---

... when you send a v2 (v3...) of a patch, you must include a little
explanations about what changed between the versions. See for example:

    https://lore.kernel.org/buildroot/ZjI4anypCjkVxtjO@waldemar-brodkorb.de/

It would have helped spot the fact that the licnese hash has changed,
see below...

>  package/uclibc/uclibc.hash | 6 +++---
>  package/uclibc/uclibc.mk   | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/uclibc/uclibc.hash b/package/uclibc/uclibc.hash
> index a10ceab54c..7097bbf99a 100644
> --- a/package/uclibc/uclibc.hash
> +++ b/package/uclibc/uclibc.hash
> @@ -1,4 +1,4 @@
> -# From https://downloads.uclibc-ng.org/releases/1.0.47/uClibc-ng-1.0.47.tar.xz.sha256
> -sha256  29a4d684a06da344ee3ee09acc2ca7649d592ae3ff848f698145c46def05efcb  uClibc-ng-1.0.47.tar.xz
> +# From https://downloads.uclibc-ng.org/releases/1.0.47/uClibc-ng-1.0.48.tar.xz.sha256
> +sha256  3bf5fc6cc5cbc454b6c478424755c6f71e7c15578a2c966f02606aa5c5596e21  uClibc-ng-1.0.48.tar.xz
>  # Locally calculated
> -sha256  6095e9ffa777dd22839f7801aa845b31c9ed07f3d6bf8a26dc5d2dec8ccc0ef3  COPYING.LIB
> +sha256  ec60b993835e2c6b79e6d9226345f4e614e686eb57dc13b6420c15a33a8996e5  COPYING.LIB

We have hashes for license files, so that we notice when the license
file changes. In which case we must assess the reason for that change,
and it must be explained in the commit log, even if briefly:

  - did the licensing terms change, and if so, what is the new license?
  - was there just a minor update, like copyright years?
  - something else?

In any case, updating the hash of a license file should not be done
without explanations.

Can you respin your series with the requested changes, please?

Do not hesitate to carry Waldemar's tested-by tags where appropriate
(i.e. on the version bump, the patch drop, but not on the internal
toolchain backend and defconfig, because it is not obvious what it
applies to).

Regards,
Yann E. MORIN.

> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index a7b18133ff..9593e18d45 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -UCLIBC_VERSION = 1.0.47
> +UCLIBC_VERSION = 1.0.48
>  UCLIBC_SOURCE = uClibc-ng-$(UCLIBC_VERSION).tar.xz
>  UCLIBC_SITE = https://downloads.uclibc-ng.org/releases/$(UCLIBC_VERSION)
>  UCLIBC_LICENSE = LGPL-2.1+
> -- 
> 2.44.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot