From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/kodi: Link to libiconv when needed
Date: Sun, 12 May 2024 20:36:52 +0200 [thread overview]
Message-ID: <ZkEMRGJpQsaTfdtm@landeda> (raw)
In-Reply-To: <ZkEFe-dn3GSQ2bdK@landeda>
Bernd, All,
On 2024-05-12 20:07 +0200, Yann E. MORIN spake thusly:
> On 2024-05-12 19:51 +0200, Bernd Kuhls spake thusly:
[--SNIP--]
> > diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
> > index 94cab237dc..301330a574 100644
> > --- a/package/kodi/kodi.mk
> > +++ b/package/kodi/kodi.mk
> > @@ -138,6 +138,7 @@ endif
> > KODI_CONF_OPTS += -DCORE_PLATFORM_NAME="$(KODI_CORE_PLATFORM_NAME)"
> >
> > ifeq ($(BR2_ENABLE_LOCALE),)
> > +KODI_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-liconv
>
> I don't understand how this is related: the defconfig you provide in the
> commit log does _not_ have BR2_ENABLE_LOCALE=y, so it can't exercise
> this code-path...
Ignore the above, I missed that it is testing agains "empty", i.e.
disabled...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-05-12 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 17:51 [Buildroot] [PATCH 1/1] package/kodi: Link to libiconv when needed Bernd Kuhls
2024-05-12 18:07 ` Yann E. MORIN
2024-05-12 18:36 ` Yann E. MORIN [this message]
[not found] ` <ZkEFe-dn3GSQ2bdK__38180.5847677001$1715537302$gmane$org@landeda>
2024-05-12 18:34 ` Bernd Kuhls
2024-05-12 21:11 ` Yann E. MORIN
2024-06-08 11:26 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkEMRGJpQsaTfdtm@landeda \
--to=yann.morin.1998@free.fr \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox