From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDCA0C25B4F for ; Sun, 12 May 2024 21:11:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 97B2660011; Sun, 12 May 2024 21:11:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Kj-oB0XghY2X; Sun, 12 May 2024 21:11:26 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 966E560653 Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 966E560653; Sun, 12 May 2024 21:11:26 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id B73B21BF35D for ; Sun, 12 May 2024 21:11:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B137C40424 for ; Sun, 12 May 2024 21:11:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OndrBuknXefa for ; Sun, 12 May 2024 21:11:23 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:e0c:1:1599::12; helo=smtp3-g21.free.fr; envelope-from=yann.morin.1998@free.fr; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 8B1FC4010F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 8B1FC4010F Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [IPv6:2a01:e0c:1:1599::12]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8B1FC4010F for ; Sun, 12 May 2024 21:11:23 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8290:3800:e05a:3b8d:ff83:9629]) (Authenticated sender: yann.morin.1998@free.fr) by smtp3-g21.free.fr (Postfix) with ESMTPSA id 2AAEF13F861; Sun, 12 May 2024 23:11:19 +0200 (CEST) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sun, 12 May 2024 23:11:18 +0200 Date: Sun, 12 May 2024 23:11:18 +0200 From: "Yann E. MORIN" To: Bernd Kuhls Message-ID: References: <20240512175117.2096550-1-bernd@kuhls.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240512175117.2096550-1-bernd@kuhls.net> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1715548281; bh=8MbhmzOgtNFchUBJtr2dUby8mVOEdj1zMOIBXKq9yoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MdgYaaJdL3doEc/k3SUHtBaOlBOdiEv92aQEadXagDkHxTCG6EXpuJody1CP+nLiP Zt62Hs4adBEgucIN8yFU/+IyFQE3P8feHiPe6rumfTQeQ4+Tg30YgYzbeiFCj9g6ao TULxMISK7LKw5uwsffZOh4uPXX3jlAYA8mOdrGxYInfmSGi/fx72LH037rcUYNPfXA gviuz4NQWp6e5QHMHPq58+Mo3mAMhz7L6gwJzN09tZ34IrwGJ7LIuBoPgiANEoTh/0 ZNRB85mSCfXWsZyuz2UheVQ3ka7+o/k9tkVlrsnYVPg3/cseMXrc1HElSyUEprH9qW SZwMECLaI0/9w== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=free.fr X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=MdgYaaJd Subject: Re: [Buildroot] [PATCH 1/1] package/kodi: Link to libiconv when needed X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Bernd, All, On 2024-05-12 19:51 +0200, Bernd Kuhls spake thusly: > Fixes build error > > /home/wbx/buildroot/output/host/lib/gcc/aarch64-buildroot-linux-uclibc/12.3.0/../../../../aarch64-buildroot-linux-uclibc/bin/ld: > build/utils/utils.a(CharsetConverter.cpp.o): undefined reference to symbol 'libiconv_open' > /home/wbx/buildroot/output/host/lib/gcc/aarch64-buildroot-linux-uclibc/12.3.0/../../../../aarch64-buildroot-linux-uclibc/bin/ld: > /home/wbx/buildroot/output/host/aarch64-buildroot-linux-uclibc/sysroot/usr/lib64/libiconv.so.2: > error adding symbols: DSO missing from command line > > reported by Waldemar: > http://lists.busybox.net/pipermail/buildroot/2024-May/690952.html > > Reproduced and fixed the build error using this defconfig: > > BR2_x86_64=y > BR2_TOOLCHAIN_BUILDROOT_UCLIBC=y > BR2_TOOLCHAIN_BUILDROOT_WCHAR=y > BR2_TOOLCHAIN_BUILDROOT_CXX=y > BR2_PER_PACKAGE_DIRECTORIES=y > BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y > BR2_PACKAGE_KODI=y > BR2_PACKAGE_MESA3D=y > BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_IRIS=y > BR2_PACKAGE_MESA3D_OPENGL_EGL=y > BR2_PACKAGE_MESA3D_OPENGL_ES=y > BR2_PACKAGE_PYTHON3=y > BR2_PACKAGE_PYTHON3_PY_ONLY=y > > Signed-off-by: Bernd Kuhls > --- > package/kodi/kodi.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk > index 94cab237dc..301330a574 100644 > --- a/package/kodi/kodi.mk > +++ b/package/kodi/kodi.mk > @@ -138,6 +138,7 @@ endif > KODI_CONF_OPTS += -DCORE_PLATFORM_NAME="$(KODI_CORE_PLATFORM_NAME)" > > ifeq ($(BR2_ENABLE_LOCALE),) > +KODI_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-liconv You recently removed an instance of -DCMAKE_EXE_LINKER_FLAG for -latomic, so that would have been OK to re-introduce one here for -liconv. However, this is not very future-proof, and it would be easy to miss that should we need to introduce other conditional linker flags. So, instead, I rewrote it like we already did for KODI_C_FLAGS. Applied to master, thanks. Regards, Yann E. MORIN. > KODI_DEPENDENCIES += libiconv > endif > > -- > 2.39.2 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot