From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/octave: add optional {Graphics, Image}Magick++ support
Date: Mon, 3 Jun 2024 20:44:16 +0200 [thread overview]
Message-ID: <Zl4PAPnPgRHHsaan@landeda> (raw)
In-Reply-To: <d8ea34fee435e9e86a3033554cf72c2c@free.fr>
Julien, All,
On 2024-06-03 20:14 +0200, Julien Olivain spake thusly:
> On 31/05/2024 22:10, Yann E. MORIN wrote:
> > On 2024-05-31 21:40 +0200, Julien Olivain spake thusly:
> > > +ifeq ($(BR2_PACKAGE_GRAPHICSMAGICK),y)
> > > +OCTAVE_CONF_OPTS += --with-magick=GraphicsMagick++
> > > +OCTAVE_DEPENDENCIES += graphicsmagick
> > > +else ifeq ($(BR2_PACKAGE_IMAGEMAGICK),y)
> > > +OCTAVE_CONF_OPTS += --with-magick=ImageMagick++
> > > +OCTAVE_DEPENDENCIES += imagemagick
> > > +else
> > > +OCTAVE_CONF_OPTS += --without-magick
> > This is material for the next branch, so should we just add
> > --without-magick on master, for correctness?
> To me, this is another instance of the grey zone between what goes in
> "master" and "next". Peter accepted the same kind of commit in master:
> https://gitlab.com/buildroot.org/buildroot/-/commit/c1723c0dfda041efb3da1d4da94909cbc0003e77
> The branch "next" was already opened.
> I understood that such a change is then a "fix" of Octave
> automatically detecting the presence of those dependencies. The build
> is not broken. It is just the support that might be enabled or not,
> depending on the build order.
Fair enough, that makes sense. No need to respin.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-06-03 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 19:40 [Buildroot] [PATCH 1/1] package/octave: add optional {Graphics, Image}Magick++ support Julien Olivain
2024-05-31 20:10 ` Yann E. MORIN
2024-06-03 18:14 ` Julien Olivain
2024-06-03 18:44 ` Yann E. MORIN [this message]
2024-06-04 21:34 ` Yann E. MORIN
2024-06-08 19:05 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl4PAPnPgRHHsaan@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox