Re: [Buildroot] [PATCH] {skalibs, execline, mdevd, s6, s6-{rc, linux-init, {linux, portable}-utils, networking}}: bump

["J. Neuschäfer via buildroot" <buildroot@buildroot.org>]

On Sat, Jun 01, 2024 at 11:13:37AM +0200, Yann E. MORIN wrote:
> J., All,
>
> On 2024-06-01 10:50 +0200, J. Neuschäfer via buildroot spake thusly:
> > On Fri, May 31, 2024 at 11:35:50AM +0200, Yann E. MORIN wrote:
> > > On 2024-05-30 22:32 +0200, J. Neuschäfer via buildroot spake thusly:
> > > > Update all skarnet.org packages to their current upstream version.
> > > >
> > > > diff COPYING (slightly different between packages):
> > > > -Copyright (c) 2011-2022 Laurent Bercot <ska-skaware@skarnet.org>
> > > > +Copyright (c) 2011-2024 Laurent Bercot <ska-skaware@skarnet.org>
> > > In a commit log, we want human-readable explanaltions, not a
> > > (pseudo-)diff; so just state something like:
> > >     Update hashes of license files for an update in copyright years.
> > I think I saw something like the diff format in existing commit, but
> > I'll rewrite it in plain text, it makes sense.
>
> Yes, there are commit logs with diff-like content; that does not mean
> that they were the best commit logs...
>
> > > > Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> > > > ---
> > > > This patch(set) updates the packages from skarnet.org. It is one commit
> > > > to avoid build failures due to incompatible versions:
> > >
> > > Thanks for the explanations. It should be in the commit log, so that
> > > when we eefer to that commit in the future, we immediately understand
> > > why they were all bumped together.
> >
> > Alright, I'll move it to the main section.
> >
> > > > For example, when
> > > > I only update skalibs to 2.14.1.1 and leave the rest as is, execline
> > > > fails to build.
> > >
> > > Is it possible to do the reverse: bump skalibs last? I.e. would the
> > > newer execline (and other packages) still build and run OK with the
> > > current skalibs version, or are they really so tightly coupled?
> >
> > With the version bump I'm aiming for, it fails to build that way too.
> > For example if I bump execline to 2.9.5.1:
> >
> > src/libexecline/el_spawn0.c:3:10: fatal error: skalibs/cspawn.h: No such file or directory
> >     3 | #include <skalibs/cspawn.h>
> >       |          ^~~~~~~~~~~~~~~~~~
> > compilation terminated.
> >
> > To split it into multiple commits, I'd probably have to make shorter bumps,
> > and bump packages multiple times.
>
> OK, then no need to repsin, I can apply the patch as-is (I'll just apply
> the little tweaks I mentioned earlier).

Alright, thanks!
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot