From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/vala: bump to version 0.56.17
Date: Sun, 2 Jun 2024 13:01:07 +0200 [thread overview]
Message-ID: <ZlxQ8_lmWG0_XcZ3@landeda> (raw)
In-Reply-To: <CADvTj4pvo2Sy1hFVbp=4hcxA1OjucbncqEyaSaX70JAv5b3puA@mail.gmail.com>
James, All,
On 2024-06-01 14:22 -0600, James Hilliard spake thusly:
> On Sat, Jun 1, 2024 at 2:03 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2024-05-31 14:22 -0600, James Hilliard spake thusly:
> > > Add new host-gobject-introspection dependency.
> > So, why is this minor version bump now requiring host-GOI?
> Well the requirement was added here, so it seems to only be used
> for finding girdir:
>
> vala: Follow the logic of GIrParser.locate_gir() to find gir files
> https://gitlab.gnome.org/GNOME/vala/-/commit/a9d38070ce86d7994b949f7cb426fbf670a953d8
But our vala-wrapper already passes the path to girdir:
$ cat package/vala/vala-wrapper
#!/bin/sh $0-@VALA_VERSION@ --vapidir=${STAGING_DIR}/usr/share/vala/vapi --girdir=${STAGING_DIR}/usr/share/gir-1.0 "$@"
In our situation, the girdir will always be ${STAGING_DIR}/usr/share/gir-1.0
and never anything else.
So adding host-GOI, which takes a while to build, as a dependency just
to get the contant value we already know, seems a little bit of an
overhead, no?
Can't we just pass GI_GIRDIR in the environment, as suggested in the
commit log you point at above?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-06-02 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 20:22 [Buildroot] [PATCH 1/1] package/vala: bump to version 0.56.17 James Hilliard
2024-06-01 20:03 ` Yann E. MORIN
2024-06-01 20:22 ` James Hilliard
2024-06-02 11:01 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlxQ8_lmWG0_XcZ3@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox