From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: yegorslists@googlemail.com
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
Date: Sun, 16 Jun 2024 13:22:29 +0200 [thread overview]
Message-ID: <Zm7K9fkXOlLrekgS@landeda> (raw)
In-Reply-To: <20240613113924.3778837-1-yegorslists@googlemail.com>
Yegor, All,
On 2024-06-13 13:39 +0200, yegorslists@googlemail.com spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Patches were taken from Gentoo:
>
> https://bugs.gentoo.org/921487
> https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
>
> Fixes:
> http://autobuild.buildroot.net/results/058578eae885ce6e206c25b5a24aa11b625adf88/
Thank you for your efforts in helping fix build failures! 👍
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
[--SNIP--]
> diff --git a/.checkpackageignore b/.checkpackageignore
> index dd1fd31e86..52b5090034 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -1067,6 +1067,8 @@ package/musl/0001-avoid-kernel-if_ether.h.patch lib_patch.Upstream
> package/musl/0002-package-musl-Make-scheduler-functions-Linux-compatib.patch lib_patch.Upstream
> package/nano/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
> package/nanocom/0001-fix-build-with-gcc-10.patch lib_patch.Upstream
> +package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch lib_patch.Upstream
> +package/ncftp/0002-ncftp-3.2.7-fix-clang.patch lib_patch.Upstream
Do not add an exclusion for new patches; instead, add an Upstream tag.
If the patches were not from upstream, then submit them and add the URL
to that submission as an Upstream tag; if the patches are not suitable
for upstream, then state so in the Upstream tag, and explain why.
See the manual:
https://buildroot.org/downloads/manual/manual.html#_additional_patch_documentation
Could you rework this and resubmit, please?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-06-16 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 11:39 [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors yegorslists
2024-06-13 11:51 ` Yegor Yefremov
2024-06-16 11:43 ` Yann E. MORIN
2024-06-16 11:22 ` Yann E. MORIN [this message]
2024-06-16 11:42 ` Yegor Yefremov
2024-06-16 11:55 ` Yann E. MORIN
2024-06-17 9:41 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zm7K9fkXOlLrekgS@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox