Re: [Buildroot] [PATCH] boot/ti-k3-r5-loader: share download files with uboot

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bryan Brattlof <bb@ti.com>
Cc: Xuanhao Shi <X15000177@gmail.com>,
	Paresh Bhagat <p-bhagat@ti.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] boot/ti-k3-r5-loader: share download files with uboot
Date: Fri, 7 Jun 2024 22:50:52 +0200	[thread overview]
Message-ID: <ZmNyrBsiNN-QGXdA@landeda> (raw)
In-Reply-To: <20240607203427.feo5giguhthammt2@bryanbrattlof.com>

Bryan, All,

On 2024-06-07 15:34 -0500, Bryan Brattlof via buildroot spake thusly:
> On June  7, 2024 thus sayeth Yann E. MORIN:
[--SNIP--]
> > Oh, so would it make sense to completely drop that big choice, and just
> > always use the same version as uboot, always?
[--SNIP--]
> There is the falcon mode option but I haven't typed out the support for 
> any K3 SoCs yet (on my to-do soon list) and I haven't seen anyone use a 
> separate fitimage made outside of U-Boot for falcon mode. But that 
> doesn't eliminate the possibility of a future package being introduced 
> to do that.

Thanks for the interesting feedback. 👍

> If you're OK with it, I would probably make ti-k3-r5-loader/ depend on 
> uboot/ and tie the versions together until that mythical falcon mode 
> package arrives.

Yes, please. Beware that you'll need to be careful on what variables you
evaluate and when:

  - some variables are used to define make dependencies; e.g. _VERSION;

  - uboot sorts after ti-k3-r5-loader, so you can't rely on variables
    that are _computed_ in uboot.mk, but only on those that come from
    Kconfig;

  - variables that are evaluated in _CMD blocks can be anything, because
    those are evaluated 'late'.

I would direct you to the doc about that, if there was one... :-(
I think _VERSION is the only that really matters, though, but look at
how it's done for linux-headers vs linux, this is the kind of ugliness
will need here too.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot