From: Brandon Maier via buildroot <buildroot@buildroot.org>
To: Neal Frager via buildroot <buildroot@buildroot.org>
Cc: ibai.erkiaga-elorza@amd.com, luca.ceresoli@bootlin.com,
thomas.petazzoni@bootlin.com, Neal Frager <neal.frager@amd.com>,
michal.simek@amd.com, yann.morin.1998@free.fr
Subject: Re: [Buildroot] [PATCH v2 1/5] boot/xilinx-prebuilt: new boot package
Date: Thu, 13 Jun 2024 12:32:30 +0000 [thread overview]
Message-ID: <Zmrm3sXCClxX6U2l@bspbox.kirk> (raw)
In-Reply-To: <20240613061423.1737631-1-neal.frager@amd.com>
Hi Neal,
On 2024.06.13 07:14, Neal Frager via buildroot wrote:
> This patch add a new boot package for downloading prebuilt firmware for Xilinx
> versal and zynqmp evaluation boards.
>
> It solves the problem of being able to verify the hash when downloading a
> prebuilt zynqmp pmufw.elf binary.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
When there are no changes on a new version, you can add any
Reviewed/Tested-by tags from previous versions.
Reviewed-by: Brandon Maier <brandon.maier@collins.com>
> ---
> V1->V2:
> - no changes
> ---
> DEVELOPERS | 2 +
> .../xilinx-prebuilt/xilinx-prebuilt.hash | 2 +
> boot/Config.in | 1 +
> boot/xilinx-prebuilt/Config.in | 40 +++++++++++++++++++
> boot/xilinx-prebuilt/xilinx-prebuilt.mk | 39 ++++++++++++++++++
> 5 files changed, 84 insertions(+)
> create mode 100644 board/xilinx/patches/xilinx-prebuilt/xilinx-prebuilt.hash
> create mode 100644 boot/xilinx-prebuilt/Config.in
> create mode 100644 boot/xilinx-prebuilt/xilinx-prebuilt.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index cf48e01037..93627a0064 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2335,8 +2335,10 @@ F: package/qt5/qt5opcua/
>
> N: Neal Frager <neal.frager@amd.com>
> F: board/versal/
> +F: board/xilinx/
> F: board/zynq/
> F: board/zynqmp/
> +F: boot/xilinx-prebuilt/
> F: configs/versal_vck190_defconfig
> F: configs/zynq_zc702_defconfig
> F: configs/zynq_zc706_defconfig
> diff --git a/board/xilinx/patches/xilinx-prebuilt/xilinx-prebuilt.hash b/board/xilinx/patches/xilinx-prebuilt/xilinx-prebuilt.hash
> new file mode 100644
> index 0000000000..c955cd79f5
> --- /dev/null
> +++ b/board/xilinx/patches/xilinx-prebuilt/xilinx-prebuilt.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 7abcba4e0e44e3a4adf9c1f971d918575226d7604dfd64a386baaa00c1c6c35f xilinx-prebuilt-xilinx_v2024.1.tar.gz
> diff --git a/boot/Config.in b/boot/Config.in
> index 87e1b7c00e..1378a04d19 100644
> --- a/boot/Config.in
> +++ b/boot/Config.in
> @@ -23,5 +23,6 @@ source "boot/ti-k3-boot-firmware/Config.in"
> source "boot/ti-k3-r5-loader/Config.in"
> source "boot/uboot/Config.in"
> source "boot/vexpress-firmware/Config.in"
> +source "boot/xilinx-prebuilt/Config.in"
>
> endmenu
> diff --git a/boot/xilinx-prebuilt/Config.in b/boot/xilinx-prebuilt/Config.in
> new file mode 100644
> index 0000000000..ec38e41993
> --- /dev/null
> +++ b/boot/xilinx-prebuilt/Config.in
> @@ -0,0 +1,40 @@
> +config BR2_TARGET_XILINX_PREBUILT
> + bool "xilinx-prebuilt"
> + depends on BR2_aarch64
> + help
> + Pre-built firmware files for Xilinx boards.
> +
> + https://github.com/Xilinx/soc-prebuilt-firmware
> +
> +if BR2_TARGET_XILINX_PREBUILT
> +
> +config BR2_TARGET_XILINX_PREBUILT_VERSION
> + string "prebuilt version"
> + default "xilinx_v2024.1"
> + help
> + Release version of Xilinx firmware.
> + Must be xilinx_v2023.1 or newer.
> +
> +config BR2_TARGET_XILINX_PREBUILT_BOARD
> + string "board name"
> + default "zcu102"
> + help
> + Name of Xilinx target board.
> + Used for installing the appropriate firmware.
> +
> +choice
> + bool "family variant"
> + default BR2_TARGET_XILINX_PREBUILT_ZYNQMP
> +
> +config BR2_TARGET_XILINX_PREBUILT_ZYNQMP
> + bool "zynqmp"
> +
> +config BR2_TARGET_XILINX_PREBUILT_KRIA
> + bool "kria"
> +
> +config BR2_TARGET_XILINX_PREBUILT_VERSAL
> + bool "versal"
> +
> +endchoice
> +
> +endif # BR2_TARGET_XILINX_PREBUILT
> diff --git a/boot/xilinx-prebuilt/xilinx-prebuilt.mk b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
> new file mode 100644
> index 0000000000..98dd18da0d
> --- /dev/null
> +++ b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
> @@ -0,0 +1,39 @@
> +################################################################################
> +#
> +# xilinx-prebuilt
> +#
> +################################################################################
> +
> +XILINX_PREBUILT_VERSION = $(call qstrip,$(BR2_TARGET_XILINX_PREBUILT_VERSION))
> +XILINX_PREBUILT_SITE = $(call github,Xilinx,soc-prebuilt-firmware,$(XILINX_PREBUILT_VERSION))
> +XILINX_PREBUILT_LICENSE = MIT
> +XILINX_PREBUILT_LICENSE_FILES = LICENSE
> +XILINX_PREBUILT_INSTALL_TARGET = NO
> +XILINX_PREBUILT_INSTALL_IMAGES = YES
> +
> +ifeq ($(BR2_TARGET_XILINX_PREBUILT_VERSAL),y)
> +define XILINX_PREBUILT_INSTALL_IMAGES_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/$(BR2_TARGET_XILINX_PREBUILT_BOARD)-versal/plm.elf \
> + $(BINARIES_DIR)/plm.elf
> + $(INSTALL) -D -m 0755 $(@D)/$(BR2_TARGET_XILINX_PREBUILT_BOARD)-versal/psmfw.elf \
> + $(BINARIES_DIR)/psmfw.elf
> + $(INSTALL) -D -m 0755 $(@D)/$(BR2_TARGET_XILINX_PREBUILT_BOARD)-versal/*.pdi \
> + $(BINARIES_DIR)/vpl_gen_fixed.pdi
> +endef
> +endif #BR2_TARGET_XILINX_PREBUILT_VERSAL
> +
> +ifeq ($(BR2_TARGET_XILINX_PREBUILT_ZYNQMP),y)
> +define XILINX_PREBUILT_INSTALL_IMAGES_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/$(BR2_TARGET_XILINX_PREBUILT_BOARD)-zynqmp/pmufw.elf \
> + $(BINARIES_DIR)/pmufw.elf
> +endef
> +endif #BR2_TARGET_XILINX_PREBUILT_ZYNQMP
> +
> +ifeq ($(BR2_TARGET_XILINX_PREBUILT_KRIA),y)
> +define XILINX_PREBUILT_INSTALL_IMAGES_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/$(BR2_TARGET_XILINX_PREBUILT_BOARD)-kria/pmufw.elf \
> + $(BINARIES_DIR)/pmufw.elf
> +endef
> +endif #BR2_TARGET_XILINX_PREBUILT_KRIA
> +
> +$(eval $(generic-package))
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-06-13 12:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 6:14 [Buildroot] [PATCH v2 1/5] boot/xilinx-prebuilt: new boot package Neal Frager via buildroot
2024-06-13 6:14 ` [Buildroot] [PATCH v2 2/5] boot/uboot.mk: new zynqmp pmufw prebuilt option Neal Frager via buildroot
2024-06-13 12:33 ` Brandon Maier via buildroot
2024-06-15 21:23 ` Yann E. MORIN
2024-06-13 6:14 ` [Buildroot] [PATCH v2 3/5] configs/zynqmp_*: migrate to xilinx-prebuilt Neal Frager via buildroot
2024-06-13 12:33 ` Brandon Maier via buildroot
2024-06-15 21:24 ` Yann E. MORIN
2024-06-13 6:14 ` [Buildroot] [PATCH v2 4/5] configs/versal_vck190_defconfig: " Neal Frager via buildroot
2024-06-13 12:33 ` Brandon Maier via buildroot
2024-06-15 21:25 ` Yann E. MORIN
2024-06-13 6:14 ` [Buildroot] [PATCH v2 5/5] package/versal-firmware: remove package Neal Frager via buildroot
2024-06-13 12:33 ` Brandon Maier via buildroot
2024-06-15 21:25 ` Yann E. MORIN
2024-06-13 12:32 ` Brandon Maier via buildroot [this message]
2024-06-15 21:20 ` [Buildroot] [PATCH v2 1/5] boot/xilinx-prebuilt: new boot package Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zmrm3sXCClxX6U2l@bspbox.kirk \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox