From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Frager, Neal" <neal.frager@amd.com>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] board/xilinx: re-add hash file for xilinx-prebuilt
Date: Thu, 20 Jun 2024 22:22:00 +0200 [thread overview]
Message-ID: <ZnSPaHGXWwfvoJuq@landeda> (raw)
In-Reply-To: <CH2PR12MB5004E97FDF74EEC7C7B0A4E6F0C82@CH2PR12MB5004.namprd12.prod.outlook.com>
Neal, All,
On 2024-06-20 13:42 +0000, Frager, Neal via buildroot spake thusly:
[--SNIP--]
> > diff --git a/board/xilinx/patches/xilinx-prebuilt/xilinx-prebuilt.hash b/board/xilinx/patches/xilinx-prebuilt/xilinx-prebuilt.hash
> > new file mode 100644
> > index 0000000000..c955cd79f5
> > --- /dev/null
> > +++ b/board/xilinx/patches/xilinx-prebuilt/xilinx-prebuilt.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha256 7abcba4e0e44e3a4adf9c1f971d918575226d7604dfd64a386baaa00c1c6c35f xilinx-prebuilt-xilinx_v2024.1.tar.gz
> Actually, wouldn't this be better if this was just a link to the hash in the
> /boot/xilinx-prebuilt directory?
I don't think so: the purpose of the per-board hash files is so that the
package can be updated without forcing the boards to be updated.
We want that the versions of "critical" packages be pinned in the
defconfig files, so that an update of the version be explicit: updating
the version should be done by someone that can test on the actual
hardware.
If you do the symlink as you suggest, then we'd have to bump the boards
exactly whjen the packag eis updated, or the version used by the
defconfigs would no longer be present in the hash file.
Regards,
Yann E. MORIN.
> Also, if you are the one who applies the xilinx-source patch set, could you
> make sure to do the same thing with the hash file for the xilinx-source
> package?
>
> https://patchwork.ozlabs.org/project/buildroot/patch/20240618074922.3555070-1-neal.frager@amd.com/
>
> Best regards,
> Neal Frager
> AMD
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-06-20 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 7:08 [Buildroot] [PATCH] board/xilinx: re-add hash file for xilinx-prebuilt Yann E. MORIN
2024-06-20 13:33 ` Frager, Neal via buildroot
2024-06-20 13:42 ` Frager, Neal via buildroot
2024-06-20 20:22 ` Yann E. MORIN [this message]
2024-06-20 20:23 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnSPaHGXWwfvoJuq@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=neal.frager@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox