Re: [Buildroot] [PATCH 2/6] utils/update-rust: add script to automatically update the rust version

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2024-06-20 12:13 -0600, James Hilliard spake thusly:
[--SNIP--]
> I don't think there's really any meaningful advantage to requests vs
> urllib.request.urlopen which is part of the standard library for this
> particular use case.

requests.get() is shorter! ;-)

So, I ended up keeping use of requests. This script is not part of the
build process; it is jus ta helper script, so it is acceptable that we
depend on a non-stdlib module, especialy such a widely available one as
requests is.

> >     os.path.basename(mk_file)[:-3].upper().replace("-", "_") + "_VERSION"
> >     pathlib.Path(mk_file).name[:-3].upper().replace("-", "_") + "_VERSION"
> > One char longer... ;-)
> pathlib.Path(mk_file).stem.upper().replace("-", "_") + "_VERSION"
> Four characters shorter. ;-)

OK, you win. ;-)

I used that in the final script.

[--SNIP--]
> > Is that really important that the script can be run from anywhere? I
> > don't think so. I can however add a check that the files we want to
> > generate and tweak do already exist, though; that's a good point.
> I'm not sure, but it should be pretty easy to implement, may also
> want to use pathlib types here.

I wanted to keep the script as simple-stupid as possible. Requiring that
it be run from Buildroot's top dir is not too strong a limitation, and
adding support for running from anywhere would just add more complexity
(evenm if not too much). So, I erred on the simplicity side, and just
catches the case where a file is not found, assuming then that we're not
running from the top dir.

Thank you for the review in any case, it is always interesting to be
challenged and to explain the choices. Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot