Re: [Buildroot] [PATCH v2] package/uclibc: fix missing m_tim issue

["J. Neuschäfer via buildroot" <buildroot@buildroot.org>]

On Tue, Aug 06, 2024 at 12:45:51PM +0200, Waldemar Brodkorb wrote:
> Hi Baruch,
> Baruch Siach wrote,
>
> > Hi Waldemar,
> >
> > On Mon, Aug 05 2024, Waldemar Brodkorb wrote:
> > > Patch from upstream to fix missing m_tim issue.
> > >
> > > Fixes:
> > >  - http://autobuild.buildroot.org/results/f07d6d6ae2331f9972974093c0503b9d3c6b914a/
> >
> > The autobuilder started showing failures like:
> >
> > In file included from /home/autobuild/autobuild/instance-12/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/sys/stat.h:106,
> >                  from /home/autobuild/autobuild/instance-12/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/fcntl.h:37,
> >                  from libslack/fio.c:72:
> > /home/autobuild/autobuild/instance-12/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/bits/stat.h:201:9: error: expected ':', ',', ';', '}' or '__attribute__' before '.' token
> >   201 |     int st_atime;
> >       |         ^~~~~~~~
> >
> > This is from
> > http://autobuild.buildroot.net/results/f3b3942b6b645d9523ab08d179a3f8aca7d6641c/
> >
> > Is this patch related to that issue?
>
> Good catch. It is related, I removed the patch and then the compile
> works. But I don't understand why it fails.
> @J.: Do you see why it fails for mips64el (n32)?

I found the issue: In the per-architecture stat.h files that I patched,
there are sections like:

	#ifdef __USE_MISC
	    /* Nanosecond resolution timestamps are stored [...] */
	    struct timespec st_atim;            /* Time of last access.  */
	    struct timespec st_mtim;            /* Time of last modification.  */
	    struct timespec st_ctim;            /* Time of last status change.  */
	# define st_atime st_atim.tv_sec        /* Backward compatibility.  */
	# define st_mtime st_mtim.tv_sec
	# define st_ctime st_ctim.tv_sec
	#else
	    __time_t st_atime;          /* Time of last access.  */
	    unsigned long int st_atimensec;     /* Nscecs of last access.  */
	    __time_t st_mtime;          /* Time of last modification.  */
	    unsigned long int st_mtimensec;     /* Nsecs of last modification.  */
	    __time_t st_ctime;          /* Time of last status change.  */
	    unsigned long int st_ctimensec;     /* Nsecs of last status change.  */
	#endif

I tried to change all instances of "#ifdef __USE_MISC" to
"#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)", but I missed some,
because MIPS has four of them (for the different ABI variants), and I
patched only the first two.

I think my original patch is salvageable, but it needs a follow-up for
MIPS and a few other architectures:

	$ find libc/sysdeps/ -name stat.h | xargs grep __USE_MISC
	libc/sysdeps/linux/sparc64/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/sparc64/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/common-generic/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/common-generic/bits/stat.h:# if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/powerpc/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/powerpc/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/m68k/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/m68k/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/x86_64/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/x86_64/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/mips/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/mips/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/mips/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/mips/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/common/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/common/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/sparc/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/sparc/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/nds32/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/nds32/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/xtensa/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/xtensa/bits/stat.h:#ifdef __USE_MISC
	libc/sysdeps/linux/ia64/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/ia64/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/kvx/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/kvx/bits/stat.h:# if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/alpha/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/frv/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)
	libc/sysdeps/linux/frv/bits/stat.h:#if defined(__USE_MISC) || defined(__USE_XOPEN2K8)

I'll see when I get around to sending the follow-up patch.


-- jn
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot