Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Waldemar Brodkorb <wbx@openadk.org>
To: buildroot@buildroot.org
Subject: [Buildroot] [PATCH] package/screen: fix compile issue
Date: Fri, 9 Aug 2024 07:01:22 +0200	[thread overview]
Message-ID: <ZrWionLijDXHPUjW@waldemar-brodkorb.de> (raw)

screen fails to compile with:
pty.c: In function 'OpenPTY':
pty.c:338:7: error: implicit declaration of function 'openpty'; did you mean 'OpenPTY'? [-Wimplicit-function-declaration]
  338 |   if (openpty(&f, &s, TtyName, NULL, NULL) != 0)
      |       ^~~~~~~
      |       OpenPTY

Add a patch to include pty.h. Similar change is already in Upstream
git repository.

Fixes:
 - http://autobuild.buildroot.net/results/a3f/a3fbd312c6946604e22540c78104e15f7a8d2281

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 .../0008-add-missing-pty.h-header.patch       | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/screen/0008-add-missing-pty.h-header.patch

diff --git a/package/screen/0008-add-missing-pty.h-header.patch b/package/screen/0008-add-missing-pty.h-header.patch
new file mode 100644
index 0000000000..3964316758
--- /dev/null
+++ b/package/screen/0008-add-missing-pty.h-header.patch
@@ -0,0 +1,26 @@
+From 8c32bc91a86ea51cad36405b592504acb31b7cba Mon Sep 17 00:00:00 2001
+From: Waldemar Brodkorb <wbx@openadk.org>
+Date: Fri, 9 Aug 2024 06:23:06 +0200
+Subject: [PATCH] add missing pty.h header
+
+Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
+Upstream: https://git.savannah.gnu.org/cgit/screen.git/tree/src/pty.c#n38
+---
+ pty.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/pty.c b/pty.c
+index 6791fd5..093273d 100644
+--- a/pty.c
++++ b/pty.c
+@@ -29,6 +29,7 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+ #include <fcntl.h>
++#include <pty.h>
+ #include <signal.h>
+ 
+ #if defined(__OpenBSD__)
+-- 
+2.39.2
+
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2024-08-09  5:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  5:01 Waldemar Brodkorb [this message]
2024-08-09 22:09 ` [Buildroot] [PATCH] package/screen: fix compile issue Thomas Petazzoni via buildroot
2024-08-10  6:33   ` Waldemar Brodkorb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrWionLijDXHPUjW@waldemar-brodkorb.de \
    --to=wbx@openadk.org \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox