Re: [Buildroot] [PATCH v2] package/ntpsec: fix host building

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Dario, All,

On 2024-08-20 19:23 +0200, Dario Binacchi spake thusly:
> The following build failure on xtensa:
> 
> Waf: Entering directory `/home/buildroot/instance-0/output-1/build/ntpsec-1.2.3/build/host'
> [1/2] Processing ntpd/ntp_parser.y
> [2/2] Compiling build/host/ntpd/ntp_parser.tab.c
> gcc: error: unrecognized command-line option '-mlongcalls'
> gcc: error: unrecognized command-line option '-mauto-litpools'
> 
> reveals that the target's CFLAGS are being used for host compilation.
> The patch fixes the host compilation by correctly setting the CFLAGS to
> be used.
> 
> It should be noted that the build script used by ntpsec applies CFLAGS
> for host compilation and --cross-cflags for target compilation.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/9321a637f2c340ce8dcb24249676bb6c44d0dfc6

I've added a little blurb that explains how long it has been happening,
so what branches it should be backported to.

> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
>   - Rework the patch following the suggestion of Thomas Petazzoni.
>   - Update the commit message
> 
>  package/ntpsec/ntpsec.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/ntpsec/ntpsec.mk b/package/ntpsec/ntpsec.mk
> index 661af788423c..3acf7745cf07 100644
> --- a/package/ntpsec/ntpsec.mk
> +++ b/package/ntpsec/ntpsec.mk
> @@ -42,6 +42,7 @@ NTPSEC_DEPENDENCIES = \
>  # --cross-compiler
>  NTPSEC_CONF_OPTS = \
>  	CC="$(HOSTCC)" \
> +	CFLAGS="$(HOST_CFLAGS)" \
>  	PYTHON_CONFIG="$(STAGING_DIR)/usr/bin/python3-config" \
>  	--libdir=/usr/lib/python$(PYTHON3_VERSION_MAJOR)/site-packages/ntp \
>  	--cross-compiler="$(TARGET_CC)" \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot