Re: [Buildroot] [PATCH 4/4] package/mesa3d: bump to 24.2.0

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Alex, All,

On 2024-08-22 17:58 +0100, Alex Bennée spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> writes:
> > On 2024-08-22 14:02 +0100, Alex Bennée spake thusly:
> >> While VirtIO Venus support went in earlier this is the first version
> >> that is known to work well.
> > This commit log is confusing: it talks about VirtIO Venus, but there is
> > no such addition in the patch.
> Support for VirtIO venus was added in patch 1/4 but testing has shown it
> needs at least 24.2.0 to work properly.

OK, thanks, I see.

So, if it needs 24.2.0, only add it after the bump to 24.2.0; there is
no point in adding an option for a feature that is known broken in
24.0.9.

Also, patch 1 does not mention Venus at all; it mentions VirtIO Vulkan,
and except for having the same first letter, the connection is not
obvious.

So, could you rework the series in a more logical order, possibly
something like:

  * 1/3 package/vkmark: add vmkark benchmarking tool
  * 2/3 package/mesa3d: bump to 24.2.0
  * 3/3 package/mesa3d: add option to enable VIRTIO vulkan driver

Also, I suspect the following patch does not belong to the series; I
don't see how it is related to mesa3d or the bump thereof:

  * board/qemu: add post-build script to aarch64_virt_defconfig

Regards,
Yann E. MORIN.

> > It however adds a dependency on
> > host-python-pyyaml, but that is not explained, and does not seem
> > related
> 
> It was a dependency I needed to add to support the build.
> 
> > to VirtIO Venus either...
> >
> > Could you clarify, please?
> >
> > Also, see below...
> >
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> ---
> >>  package/mesa3d-headers/mesa3d-headers.mk | 2 +-
> >>  package/mesa3d/mesa3d.hash               | 5 ++---
> >>  package/mesa3d/mesa3d.mk                 | 3 ++-
> >>  3 files changed, 5 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/package/mesa3d-headers/mesa3d-headers.mk b/package/mesa3d-headers/mesa3d-headers.mk
> >> index 33c60b285f..98afb77a9c 100644
> >> --- a/package/mesa3d-headers/mesa3d-headers.mk
> >> +++ b/package/mesa3d-headers/mesa3d-headers.mk
> >> @@ -12,7 +12,7 @@ endif
> >>  
> >>  # Not possible to directly refer to mesa3d variables, because of
> >>  # first/second expansion trickery...
> >> -MESA3D_HEADERS_VERSION = 24.0.9
> >> +MESA3D_HEADERS_VERSION = 24.2.0
> >>  MESA3D_HEADERS_SOURCE = mesa-$(MESA3D_HEADERS_VERSION).tar.xz
> >>  MESA3D_HEADERS_SITE = https://archive.mesa3d.org
> >>  MESA3D_HEADERS_DL_SUBDIR = mesa3d
> >> diff --git a/package/mesa3d/mesa3d.hash b/package/mesa3d/mesa3d.hash
> >> index d506d398b8..1ff11f9bd8 100644
> >> --- a/package/mesa3d/mesa3d.hash
> >> +++ b/package/mesa3d/mesa3d.hash
> >> @@ -1,5 +1,4 @@
> >> -# From https://lists.freedesktop.org/archives/mesa-announce/2024-June/000764.html
> >> -sha256  51aa686ca4060e38711a9e8f60c8f1efaa516baf411946ed7f2c265cd582ca4c  mesa-24.0.9.tar.xz
> >> -sha512  de2ee6c9df1fc106ee10befe0a76be1e9cfe83d65dbdb83bad6d8d7cfaa085232fb115293a1a790b37b50b1fe14bd58aafbcfe5a15e953b5901a7105d57569a5  mesa-24.0.9.tar.xz
> >> +# From https://docs.mesa3d.org/relnotes/24.2.0.html
> >> +sha256  c02bb72cea290f78b11895a0c95c7c92394f180d7ff66d4a762ec6950a58addf  mesa-24.2.0.tar.xz
> >
> > There previously was sha256 _and_ sha512 hashes, but now you only add a
> > sha256 one. Can you extend a little blurb about that, please?
> 
> Sure - only the sha256 was in the relase announcement. I could calculate
> one if you want?
> 
> >
> > Regards,
> > Yann E. MORIN.
> >
> >>  # License
> >>  sha256  a00275a53178e2645fb65be99a785c110513446a5071ff2c698ed260ad917d75  docs/license.rst
> >> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> >> index d3b5010648..29f26c5663 100644
> >> --- a/package/mesa3d/mesa3d.mk
> >> +++ b/package/mesa3d/mesa3d.mk
> >> @@ -5,7 +5,7 @@
> >>  ################################################################################
> >>  
> >>  # When updating the version, please also update mesa3d-headers
> >> -MESA3D_VERSION = 24.0.9
> >> +MESA3D_VERSION = 24.2.0
> >>  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
> >>  MESA3D_SITE = https://archive.mesa3d.org
> >>  MESA3D_LICENSE = MIT, SGI, Khronos
> >> @@ -21,6 +21,7 @@ MESA3D_DEPENDENCIES = \
> >>  	host-bison \
> >>  	host-flex \
> >>  	host-python-mako \
> >> +	host-python-pyyaml \
> >>  	expat \
> >>  	libdrm \
> >>  	zlib
> >> -- 
> >> 2.39.2
> >> 
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot@buildroot.org
> >> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> -- 
> Alex Bennée
> Virtualisation Tech Lead @ Linaro
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot