Re: [Buildroot] [PATCH] package/aer-inject: Fix build error due to missing basename() prototype

["J. Neuschäfer via buildroot" <buildroot@buildroot.org>]

On Mon, Aug 12, 2024 at 09:41:24PM +0200, Thomas Petazzoni wrote:
> Hello J,

Hello Thomas,

> Thanks a lot for your patch, which I have applied. I just have a few
> very, very minor suggestions to further improve your next patches.
>
> First of all, I personally like that the commit title starts with a
> lower-case letter, i.e: "package/aer-inject: fix ..." rather than
> "package/aer-inject: Fix ...".

Ah, force of habit…

>
> On Sun, 11 Aug 2024 12:34:25 +0200
> J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:
>
> > Fixes several build failures such as:
>
> Please write just "Fixes:". This way, patchwork detects it's a patch
> fixes something, and it flags it as such.
> See https://patchwork.ozlabs.org/project/buildroot/list/, where the column A/F/R/T flags the patches that have a Acked-by:, a Fixes:, a Reviewed-by: or a Tested-by:.
>
> >   http://autobuild.buildroot.net/results/e61/e613fc777051be6325d7e3c088d5f723fab518fa/build-end.log
>
> We like to have just:
>
>   http://autobuild.buildroot.net/results/e613fc777051be6325d7e3c088d5f723fab518fa/
>
> i.e don't point to build-end.log, but to the build result, and drop the
> extra /e61/ in the URL.

Noted!

> > This patch is from Kuppuswamy Sathyanarayanan's fork of aer-inject. An
> > alternative to including the patch would be to switch to this fork as
> > Buildroot's idea of upstream. Currently, it is the only change in the
> > fork, though.
>
> I guess at this point, it's fine to keep things as they are. How
> "official" is each of those two aer-inject Git repos?

I took a deeper look right now, and found this on the linux-pci mailing list:

https://lore.kernel.org/linux-pci/20240416055035.200085-1-sathyanarayanan.kuppuswamy@linux.intel.com/

 Subject: [PATCH v1] PCI/AER: Update aer-inject tool source URL
 -	     https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/
 +	     https://github.com/intel/aer-inject.git

This patch was merged, so I think the github.com/intel URL counts as official.


-- jn
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot