Re: [Buildroot] [PATCH v2 1/2] package/babeld: update URL site

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Dario, All,

On 2024-08-31 20:36 +0200, Dario Binacchi spake thusly:
> On Sat, Aug 31, 2024 at 6:25 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > On Sat, 31 Aug 2024 16:54:49 +0200
> > Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
[--SNIP--]
> > > -BABELD_SITE = http://www.pps.univ-paris-diderot.fr/~jch/software/files
> > > +BABELD_SITE = $(call github,jech,babeld,refs/tags)
> > This looks odd. Isn't the version needed somewhere?
> It seemed strange to me as well. Indeed, I don't see other similar
> _SITE settings in Buildroot.
> But if I go to the GitHub URL, these are the tarball addresses:
> https://github.com/jech/babeld/archive/refs/tags/babeld-1.9.2.tar.gz
> ...
> https://github.com/jech/babeld/archive/refs/tags/babeld-1.13.1.tar.gz
> Am I missing something?

The github macro is to be called that way:
    $(call github,user,package,version)

See the manual, section 18.25.4 How to add a package from GitHub;
    https://nightly.buildroot.org/manual.html#github-download-url

so for babeld:
    $(call github,jech,babeld,babeld-$(BABELD_VERSION))

See also the myriads of existing calls in the tree:
    git grep call\ github,

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot