Re: [Buildroot] [PATCH 1/2] scripts/cve: Avoid to do a complete clone of cve git repository

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Michael, All,

On 2024-09-02 09:41 +0200, Michael Trimarchi spake thusly:
> Just a simple clone --depth 1 should be enough to parse the
> cve and generate the pkg-stats report. The space now does
> not take in account of the full history and only use 2.2Gb

I just did both a full clone and a depth-1 clone, and the size delta is
not that much: 2.9GiB vs. 2.2GiB, so we're still in the same league.

Still, the download size does change: from 983.55MiB down to 270.78MiB;
the remote has to compress objects specifically for the depth-1 clone,
which takes a bit of time, but there less deltas to resolve locally, so
it's a net time win too: 2m17s vs 1min7s (on a 100Mbps link).

Is it eventually worth it? I like things to be simple rather than have
complex heuristics, and storage nowadays is cheap, and bandwidth is only
really paid on the first clone, since the following calls would only
pull what's missing, which will eventually cause the local clone to grow
to a size that would not differ by much if the first clone had been a
full one.

So, I 'm a bit comnficted about that one, but would tend to say no...
Leaving pending for other maintainers to chime in.

Regards,
Yann E. MORIN.

> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  support/scripts/cve.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/scripts/cve.py b/support/scripts/cve.py
> index e25825581e..7d115a28b5 100755
> --- a/support/scripts/cve.py
> +++ b/support/scripts/cve.py
> @@ -82,7 +82,7 @@ class CVE:
>              # happily clones into an empty directory.
>              os.makedirs(nvd_git_dir)
>              subprocess.check_call(
> -                ["git", "clone", NVD_BASE_URL, nvd_git_dir],
> +                ["git", "clone", "--depth", "1", NVD_BASE_URL, nvd_git_dir],
>                  stdout=subprocess.DEVNULL,
>                  stderr=subprocess.DEVNULL,
>              )
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot