Re: [Buildroot] [PATCH v2 1/1] package/ipmitool: download enterprise-numbers versioned

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Floris Bos <bos@je-eigen-domein.nl>,
	Heiko Thiery <heiko.thiery@gmail.com>,
	linux-amarula@amarulasolutions.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/ipmitool: download enterprise-numbers versioned
Date: Wed, 4 Sep 2024 20:17:19 +0200	[thread overview]
Message-ID: <ZtikL2bVIPqtvgJA@landeda> (raw)
In-Reply-To: <20240904174021.2670289-1-dario.binacchi@amarulasolutions.com>

Dario, All,

Thanks for your persistemce in fixing this issue! :-)

On 2024-09-04 19:40 +0200, Dario Binacchi spake thusly:
> The previous default URL used for the PEN registry was not stable and
> could change at any time, making it unacceptable to have to update its
> hash every time. Following the suggestions provided by Thomas Petazzoni,
> the file is now downloaded from a GitHub repository, which means it is
> versioned.
[--SNIP--]
> diff --git a/package/ipmitool/Config.in b/package/ipmitool/Config.in
> index 9516ff8596d3..783bd263756e 100644
> --- a/package/ipmitool/Config.in
> +++ b/package/ipmitool/Config.in
> @@ -11,7 +11,7 @@ if BR2_PACKAGE_IPMITOOL
>  
>  config BR2_PACKAGE_IPMITOOL_PEN_REG_URI
>  	string "IANA PEN registry URL or path"
> -	default "https://www.iana.org/assignments/enterprise-numbers.txt"
> +	default "https://github.com/larseggert/iana-assignments/raw/6eaf55c1c24941db2546da242029ceeaba3f9dfc/enterprise-numbers/enterprise-numbers"

That's unfortunately not enough, see below...

>  	help
>  	  Enter an URL or a file path to the PEN registry to use.
>  
> diff --git a/package/ipmitool/ipmitool.hash b/package/ipmitool/ipmitool.hash
> index c3b298e3ba5d..f2e91ef9000d 100644
> --- a/package/ipmitool/ipmitool.hash
> +++ b/package/ipmitool/ipmitool.hash
> @@ -1,3 +1,4 @@
>  # Locally computed:
>  sha256  48b010e7bcdf93e4e4b6e43c53c7f60aa6873d574cbd45a8d86fa7aaeebaff9c  ipmitool-1_8_19.tar.gz
>  sha256  b7e2382a8be43b5f6cb092f2d2bda163bf1a1938be9300f821a845cbcd535f56  COPYING
> +sha256  45eca3cadadd8a82736d83b130106da22cd49a34d287c9c4c7f10dffb4579f4f  enterprise-numbers

Indeed, the filename itself is still unversioned, so when we update the
version in the URL, the local file would not change name, and thus
that'd cause the same issues I explained earlier.

I tried a few hacks, notably the infamous GET parameters, like:

https://github.com/larseggert/iana-assignments/raw/6eaf[...]enterprise-numbers/enterprise-numbers&path=foo/enterprise-numbers-6eaf[...].txt

and various variants of that, but to not avail... So, unless you can
come up with a way to hack a verioned filename in the URL, we'll have to
introduce a dedicated package... :-/

Regards,
Yann E. MORIN.

> -- 
> 2.43.0
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot