Re: [Buildroot] [PATCH v3] docs/manual: use space-separated list for BR2_EXTERNAL

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Fiona Klute \(WIWA\)" <fiona.klute@gmx.de>,
	Brandon Maier <Brandon.Maier@collins.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] docs/manual: use space-separated list for BR2_EXTERNAL
Date: Thu, 5 Sep 2024 21:56:26 +0200	[thread overview]
Message-ID: <ZtoM6k0EaDsZa4mV@landeda> (raw)
In-Reply-To: <20240905213522.2a476624@windsurf>

Thomas, All,

+Arnout whom I forgot to Cc in my patch.

On 2024-09-05 21:35 +0200, Thomas Petazzoni spake thusly:
> On Wed,  4 Sep 2024 22:53:54 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > Change the documentation to only mention using a space-separated list.
[--SNIP--]
> I'm afraid I'm personally finding that this not going in the right
> direction. I didn't follow the discussions on v1 and v2, but on my
> side, I would very, very, very much prefer to use colon as a separator
> in the BR2_EXTERNAL variable. The PATH variable is like this, it works
> well, and I believe the principle of least surprise should encourage us
> to follow that and use colon as a separator.

The thing is that all the other lists are space-separated:
    BR2_ROOTFS_DEVICE_TABLE
    BR2_ROOTFS_STATIC_DEVICE_TABLE
    BR2_TARGET_TZ_ZONELIST
    BR2_ROOTFS_USERS_TABLES
    BR2_ROOTFS_OVERLAY
    BR2_ROOTFS_PRE_BUILD_SCRIPT
    BR2_ROOTFS_POST_BUILD_SCRIPT
    BR2_ROOTFS_POST_FAKEROOT_SCRIPT
    BR2_ROOTFS_POST_IMAGE_SCRIPT

The list goes on and on, notably the options to specify the lists of
.config fragments for the kernel, uclibc, uboot etc...

In fact, BR2_EXTERNAL is the odd one; it's the only one were we expect
a colon-separated list. Also, lists in Makefile are necessarily space-
separated, we can't handle paths with spaces in them anyway. I think we
should just accept that space is the splitting character for lists.

(v1 had too many typoes that I was ashamed enough to quickly respin v2,
which added the comment in the script, as explained in the post-commit
changelogs ;-) )

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot