From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/pkg-cargo: don't install crates tracking
Date: Thu, 5 Sep 2024 22:01:47 +0200 [thread overview]
Message-ID: <ZtoOK5yQ8hw1LsOs@landeda> (raw)
In-Reply-To: <20240905210725.49e2524c@windsurf>
Thomas, All,
On 2024-09-05 21:07 +0200, Thomas Petazzoni spake thusly:
> On Wed, 4 Sep 2024 22:42:34 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > Closes: #17
>
> Thanks for the patch, which I have applied to next. However, I would
> really like:
>
> Closes: #17
>
> to be:
>
> Fixes:
>
> https://gitlab.com/buildroot.org/buildroot/-/issues/17
As explained on IRC, and for all to know: using "Fixes: #17" makes
Gitlab automatically close the corresponding issue with a reference to
the proper commit log.
It seems GitLab was able to notice that this commit referenced the
issue, so if we go for the full URL, I think we should put it on the
same line as the "Fixes:" tag.
> For two reasons:
>
> (1) For autobuilder failures we use a full URL, not just the
> identifier, so we should do the same for Gitlab issue. It also makes
> them directly clickable from the commit log, which is really nice,
> and makes it very clear that it's fixing a Gitlab issue
>
> (2) Fixes: gets picked up by patchwork and not Closes:
>
> I adjusted this when committing, so this was really just to hopefully
> establish what we consider to be our best practice on this matter :-)
I think it sets the wrong example, then, and that we'll have to settle
on an actual best practice. ;-)
Then I'll have to address another issue so that I can properly tag it in
my commit log! :-]
Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-09-05 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 20:42 [Buildroot] [PATCH] package/pkg-cargo: don't install crates tracking Yann E. MORIN
2024-09-05 9:00 ` Yann E. MORIN
2024-09-05 19:07 ` Thomas Petazzoni via buildroot
2024-09-05 20:01 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtoOK5yQ8hw1LsOs@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox