Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Floris Bos <bos@je-eigen-domein.nl>,
	Heiko Thiery <heiko.thiery@gmail.com>,
	linux-amarula@amarulasolutions.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 2/2] package/ipmitool: use versioned or local PEN registry
Date: Fri, 6 Sep 2024 20:33:56 +0200	[thread overview]
Message-ID: <ZttLFI21Y94ar9HY@landeda> (raw)
In-Reply-To: <20240906171503.3495498-2-dario.binacchi@amarulasolutions.com>

Dario, All,

On 2024-09-06 19:15 +0200, Dario Binacchi spake thusly:
[--SNIP--]
> diff --git a/package/ipmitool/Config.in b/package/ipmitool/Config.in
> index 9516ff8596d3..c4b3ee734d44 100644
> --- a/package/ipmitool/Config.in
> +++ b/package/ipmitool/Config.in
> @@ -9,14 +9,34 @@ config BR2_PACKAGE_IPMITOOL
>  
>  if BR2_PACKAGE_IPMITOOL
>  
> -config BR2_PACKAGE_IPMITOOL_PEN_REG_URI
> -	string "IANA PEN registry URL or path"
> -	default "https://www.iana.org/assignments/enterprise-numbers.txt"

You forgot to add legacy handling for this variable:

    config BR2_PACKAGE_IPMITOOL_PEN_REG_URI
        string "IANA PEN registry move to iana-assignment package"
        help
          Installation of the IANA PEN is now handled by the
          iana-assignment package; to install a custom PEN,
          use a rootfs-overlay for example.


    config BR2_PACKAGE_IPMITOOL_PEN_REG_URI_WRAP
        bool
        default y if BR2_PACKAGE_IPMITOOL_PEN_REG_URI != ""
        select BR2_LEGACY

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-09-06 18:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 17:15 [Buildroot] [PATCH v3 1/2] package/iana-assignments: new package Dario Binacchi
2024-09-06 17:15 ` [Buildroot] [PATCH v3 2/2] package/ipmitool: use versioned or local PEN registry Dario Binacchi
2024-09-06 18:16   ` Yann E. MORIN
2024-09-06 18:33   ` Yann E. MORIN [this message]
2024-09-06 18:10 ` [Buildroot] [PATCH v3 1/2] package/iana-assignments: new package Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZttLFI21Y94ar9HY@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=bos@je-eigen-domein.nl \
    --cc=buildroot@buildroot.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=heiko.thiery@gmail.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox