Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Gustavo Heinz <gustavo@gsthnz.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-m2crypto: bump to version 0.42.0
Date: Mon, 16 Sep 2024 11:51:27 +0200	[thread overview]
Message-ID: <Zuf_n3SFObkfWBOL@landeda> (raw)
In-Reply-To: <20240915212816.1645997-1-james.hilliard1@gmail.com>

James, All,

On 2024-09-15 15:28 -0600, James Hilliard spake thusly:
> Set openssl path via env instead of build options.

You are _describing_ the change, you are not _explaining_ it. It is
pretty easy to spot that the options are dropped and that the path
is now passed in an environment variable.

But why is that needed? What's the rationale for doing it? Is it
required by the bump, or is it something that can be done before or
after? Explaining this may ring a bell that maybe the change should (or
should not) be backported.

Regards,
Yann E. MORIN.

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/python-m2crypto/python-m2crypto.hash |  4 ++--
>  package/python-m2crypto/python-m2crypto.mk   | 10 ++++------
>  2 files changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/package/python-m2crypto/python-m2crypto.hash b/package/python-m2crypto/python-m2crypto.hash
> index 782837081e..aa8fe09c14 100644
> --- a/package/python-m2crypto/python-m2crypto.hash
> +++ b/package/python-m2crypto/python-m2crypto.hash
> @@ -1,5 +1,5 @@
>  # md5, sha256 from https://pypi.org/pypi/m2crypto/json
> -md5  280c20072afbe7010cf9e9620ea25c7b  M2Crypto-0.40.1.tar.gz
> -sha256  bbfd113ec55708c05816252a4f09e4237df4f3bbfc8171cbbc33057d257bbb30  M2Crypto-0.40.1.tar.gz
> +md5  b88bcb1d4aeb817f91eb627d08b673a2  m2crypto-0.42.0.tar.gz
> +sha256  42b62df2caf623161b1d643a7235464c2fe2a3105049ebc498a6d47dc08f64b4  m2crypto-0.42.0.tar.gz
>  # Locally computed sha256 checksums
>  sha256  4eca478396f4b2b020729a111fce3f096456d74500bfd8f2b0388c3c69f997c0  LICENCE
> diff --git a/package/python-m2crypto/python-m2crypto.mk b/package/python-m2crypto/python-m2crypto.mk
> index 6c07f42d06..79dfc1beb2 100644
> --- a/package/python-m2crypto/python-m2crypto.mk
> +++ b/package/python-m2crypto/python-m2crypto.mk
> @@ -4,17 +4,15 @@
>  #
>  ################################################################################
>  
> -PYTHON_M2CRYPTO_VERSION = 0.40.1
> -PYTHON_M2CRYPTO_SOURCE = M2Crypto-$(PYTHON_M2CRYPTO_VERSION).tar.gz
> -PYTHON_M2CRYPTO_SITE = https://files.pythonhosted.org/packages/9e/a3/9433817493ea250db67a05de3361cb0a1d58531847d50406f2f28455e68c
> +PYTHON_M2CRYPTO_VERSION = 0.42.0
> +PYTHON_M2CRYPTO_SOURCE = m2crypto-$(PYTHON_M2CRYPTO_VERSION).tar.gz
> +PYTHON_M2CRYPTO_SITE = https://files.pythonhosted.org/packages/85/9f/b8977ce2971cf5f823db3fdb31e7e061b9662da318a17b6bf0c653f84aee
>  PYTHON_M2CRYPTO_SETUP_TYPE = setuptools
>  PYTHON_M2CRYPTO_LICENSE = MIT
>  PYTHON_M2CRYPTO_LICENSE_FILES = LICENCE
>  PYTHON_M2CRYPTO_CPE_ID_VENDOR = m2crypto_project
>  PYTHON_M2CRYPTO_CPE_ID_PRODUCT = m2crypto
>  PYTHON_M2CRYPTO_DEPENDENCIES = openssl host-swig
> -PYTHON_M2CRYPTO_BUILD_OPTS = \
> -	-C--build-option=build_ext \
> -	-C--build-option=--openssl=$(STAGING_DIR)/usr
> +PYTHON_M2CRYPTO_ENV = OPENSSL_PATH="$(STAGING_DIR)/usr"
>  
>  $(eval $(python-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-09-16  9:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-15 21:28 [Buildroot] [PATCH 1/1] package/python-m2crypto: bump to version 0.42.0 James Hilliard
2024-09-16  9:51 ` Yann E. MORIN [this message]
2024-09-16 14:57   ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zuf_n3SFObkfWBOL@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=gustavo@gsthnz.com \
    --cc=james.hilliard1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox