Re: [Buildroot] [PATCH v2 3/4] package/python-sdbus-networkmanager: new package

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Raphaël Mélotte" <raphael.melotte@mind.be>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/4] package/python-sdbus-networkmanager: new package
Date: Mon, 16 Sep 2024 13:17:44 +0200	[thread overview]
Message-ID: <ZugT2E3Y1M3TjNt_@landeda> (raw)
In-Reply-To: <20240705091409.3370272-3-raphael.melotte@mind.be>

Raphaël, All,

On 2024-07-05 11:14 +0200, Raphaël Mélotte via buildroot spake thusly:
> Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
> ---
[--SNIP--]
> diff --git a/package/python-sdbus-networkmanager/Config.in b/package/python-sdbus-networkmanager/Config.in
> new file mode 100644
> index 0000000000..70ec11414c
> --- /dev/null
> +++ b/package/python-sdbus-networkmanager/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_PYTHON_SDBUS_NETWORKMANAGER
> +	bool "python-sdbus-networkmanager"
> +	depends on BR2_PACKAGE_NETWORK_MANAGER # runtime
> +	select BR2_PACKAGE_PYTHON_SDBUS # runtime

You forgot to propagate the dependencies from pytrhon-sdbus.

> +	help
> +	  NetworkManager binds for sdbus.

s/binds/bindings/

> +	  https://github.com/igo95862/python-sdbus
> +
> +comment "python-sdbus-networkmanager needs network-manager"
> +	depends on !BR2_PACKAGE_NETWORK_MANAGER

You'll alspo need to update the dependencies list of the comment.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot