Re: [Buildroot] [PATCH/next 5/6] package/{mesa3d, mesa3d-headers}: bump version to 24.2.0

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Andy Yan <andyshrk@163.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Daniel Lang <dalang@gmx.at>, Bernd Kuhls <bernd@kuhls.net>,
	Samuel Martin <s.martin49@gmail.com>,
	buildroot@buildroot.org, Romain Naour <romain.naour@gmail.com>,
	Valentin Korenblit <valentinkorenblit@gmail.com>
Subject: Re: [Buildroot] [PATCH/next 5/6] package/{mesa3d, mesa3d-headers}: bump version to 24.2.0
Date: Mon, 16 Sep 2024 21:16:17 +0200	[thread overview]
Message-ID: <ZuiEAeBfrMsUWAjC@landeda> (raw)
In-Reply-To: <19f56d2a.1aaa.191f9e145f6.Coremail.andyshrk@163.com>

Amndi, All,

On 2024-09-16 16:09 +0800, Andy Yan spake thusly:
> At 2024-09-14 17:00:51, "Andy Yan" <andyshrk@163.com> wrote:
> >I get a build error on Ubuntu 22.04：
> >
> >output/build/mesa3d-24.2.0/meson.build:171: WARNING: `gallium-drivers=swrast` is a deprecated alias for `gallium-drivers=softpipe,llvmpipe` and will be removed in version 25.0
> >output/build/mesa3d-24.2.0/meson.build:502: WARNING: cannot auto-detect -mtls-dialect when cross-compiling, using compiler default
> >Dependency libglvnd skipped: feature glvnd disabled
> >Dependency vdpau skipped: feature gallium-vdpau disabled
> >Program glslangValidator found: NO
> >Dependency libva skipped: feature gallium-va disabled
> >Program python3 found: YES (/srv/WorkSpace/opensource/buildroot/output/host/bin/python3)
> >
> >output/build/mesa3d-24.2.0/meson.build:967:2: ERROR: Problem encountered: Python (3.x) yaml module (PyYAML) required to build mesa.
[--SNIP--]
> I found the build error was gone when I add  host-python-pyyaml  to MESA3D_DEPENDENCIES，
> Should this be added there ？

It should indeed probably be added, but conditionally, i.e. only when
the affected driver is enabled, somnething like:

    ifeq ($(BR2_PACKAGE_MESA3D_XXXX),y)
    MESA3D_DEPENDENCIES += host-python-pyyaml
    ...
    endif

Reuse an existing conditional block.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot