From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 03/12] configs/amarula_a64_relic_defconfig: remove BR2_PACKAGE_HOST_ANDROID_TOOLS_FASTBOOT
Date: Tue, 21 Apr 2020 21:48:23 +0200 [thread overview]
Message-ID: <a04d490d-e6e4-5e16-6047-8488b9f83564@gmail.com> (raw)
In-Reply-To: <20200421214337.3ae2992a@windsurf.home>
Hi Thomas,
Le 21/04/2020 ? 21:43, Thomas Petazzoni a ?crit?:
> On Tue, 21 Apr 2020 19:26:37 +0200
> Romain Naour <romain.naour@gmail.com> wrote:
>
>> This option is lost while loading the defconfig with:
>> make amarula_a64_relic_defconfig
>>
>> This fixes the new defconfig check.
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> If android tools is really required for this defconfig,
>> BR2_PACKAGE_HOST_ANDROID_TOOLS must be selected first.
(*)
>> ---
>> configs/amarula_a64_relic_defconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/configs/amarula_a64_relic_defconfig b/configs/amarula_a64_relic_defconfig
>> index f2e7e7f965..5a62fbf6c4 100644
>> --- a/configs/amarula_a64_relic_defconfig
>> +++ b/configs/amarula_a64_relic_defconfig
>> @@ -40,7 +40,6 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>> BR2_TARGET_GENERIC_ISSUE="Welcome to Amarula A64-Relic"
>> BR2_TARGET_ROOTFS_EXT2=y
>> BR2_TARGET_ROOTFS_EXT2_4=y
>> -BR2_PACKAGE_HOST_ANDROID_TOOLS_FASTBOOT=y
>
> The intention is to have android-tools for the host enabled, because
> board/amarula/a64-relic/readme.txt makes use of fastboot to reflash the
> board.
>
> So the proper fix is to add:
>
> BR2_PACKAGE_HOST_ANDROID_TOOLS=y
>
> and of course adjust the commit log accordingly. No need to resend the
> whole series for that, we can fix when applying.
Thanks for the review, I was not 100% sure, see (*).
Best regards,
Romain
>
> Best regards,
>
> Thomas
>
next prev parent reply other threads:[~2020-04-21 19:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 17:26 [Buildroot] [PATCHv2 01/12] support/scripts: add check-dotconfig.py Romain Naour
2020-04-21 17:26 ` [Buildroot] [PATCHv2 02/12] gitlab-ci: check generated config files Romain Naour
2020-04-21 19:44 ` Thomas Petazzoni
2020-04-21 19:52 ` Yann E. MORIN
2020-04-21 17:26 ` [Buildroot] [PATCHv2 03/12] configs/amarula_a64_relic_defconfig: remove BR2_PACKAGE_HOST_ANDROID_TOOLS_FASTBOOT Romain Naour
2020-04-21 19:43 ` Thomas Petazzoni
2020-04-21 19:48 ` Romain Naour [this message]
2020-04-21 17:26 ` [Buildroot] [PATCHv2 04/12] configs: fix typo BR2_TARGET_ROOTFS_EXT2_4 Romain Naour
2020-04-21 19:29 ` Fabio Estevam
2020-04-21 17:26 ` [Buildroot] [PATCHv2 05/12] configs:minnowboard_max-graphical_defconfig: re-enable GLX support Romain Naour
2020-05-07 21:11 ` Peter Korsgaard
2020-04-21 17:26 ` [Buildroot] [PATCHv2 06/12] configs/nanopi_r1_defconfig: remove BR2_TARGET_UBOOT_BOARD_DEFCONFIG Romain Naour
2020-04-21 17:26 ` [Buildroot] [PATCHv2 07/12] configs: remove BR2_PACKAGE_QT5BASE_LICENSE_APPROVED Romain Naour
2020-04-21 19:54 ` Yann E. MORIN
2020-04-21 17:26 ` [Buildroot] [PATCHv2 08/12] configs/engicam_imx6qdl_icore_qt5_defconfig: needs udev to select glmark2 Romain Naour
2020-04-21 19:28 ` Fabio Estevam
2020-04-21 17:26 ` [Buildroot] [PATCHv2 09/12] configs/olimex_a20_olinuxino_lime{, 2}_defconfig: use a glibc toolchain Romain Naour
2020-04-21 17:26 ` [Buildroot] [PATCHv2 10/12] configs/qemu_ppc_virtex_ml507_defconfig: select BR2_POWERPC_SOFT_FLOAT Romain Naour
2020-04-21 17:26 ` [Buildroot] [PATCHv2 11/12] configs/qemu_riscv*: remove BR2_TARGET_OPENSBI_USE_PLAT Romain Naour
2020-04-21 17:26 ` [Buildroot] [PATCHv2 12/12] gitlab-ci: check all defconfigs on every push Romain Naour
2020-04-21 20:23 ` Yann E. MORIN
2020-04-21 20:09 ` [Buildroot] [PATCHv2 01/12] support/scripts: add check-dotconfig.py Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a04d490d-e6e4-5e16-6047-8488b9f83564@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox