public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: buildroot@buildroot.org, Bernd Kuhls <bernd@kuhls.net>,
	Romain Naour <romain.naour@gmail.com>, Bryan Brattlof <bb@ti.com>,
	Michael Walle <michael@walle.cc>
Subject: Re: [Buildroot] [PATCH] package/mesa3d: add support for imagination vulkan driver
Date: Sat, 12 Jul 2025 14:43:15 +0200	[thread overview]
Message-ID: <a2186a22be0f15499a563c1aa6d6d57f@free.fr> (raw)
In-Reply-To: <20250711120625.316250-1-heiko.thiery@gmail.com>

Hi Heiko,

Thanks for the patch.

On 11/07/2025 14:06, Heiko Thiery wrote:
> This adds the experimental vulkan support for the PowerVR rogue
> architecture.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  package/mesa3d/Config.in | 8 ++++++++
>  package/mesa3d/mesa3d.mk | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index b5c1d92d68..7ec8fd2f76 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -359,6 +359,14 @@ config BR2_PACKAGE_MESA3D_VULKAN_DRIVER_BROADCOM
>  	help
>  	  Vulkan broadcom driver.
> 
> +config BR2_PACKAGE_MESA3D_VULKAN_DRIVER_IMAGINATION
> +	bool "Vulkan imagination driver (experimental)"
> +	depends on BR2_arm || BR2_aarch64
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libxshmfence

BR2_PACKAGE_XLIB_LIBXSHMFENCE is selected by BR2_PACKAGE_MESA3D_DRIVER
only if BR2_PACKAGE_XORG7 is also selected. See:
https://gitlab.com/buildroot.org/buildroot/-/blob/2025.05/package/mesa3d/Config.in#L72

In that case, why this dependency is not:

     depends on BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_PACKAGE_XORG7 # 
libxshmfence

like most of the other drivers?

Could you update this dependency or add an explanation please?

> +	select BR2_PACKAGE_MESA3D_VULKAN_DRIVER
> +	help
> +	  Vulkan imagination driver.
> +
>  config BR2_PACKAGE_MESA3D_VULKAN_DRIVER_INTEL
>  	bool "Vulkan Intel driver"
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_PACKAGE_XORG7 # 
> libxshmfence

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-07-12 12:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11 12:06 [Buildroot] [PATCH] package/mesa3d: add support for imagination vulkan driver Heiko Thiery
2025-07-12 12:43 ` Julien Olivain via buildroot [this message]
2025-07-14  6:14   ` Heiko Thiery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2186a22be0f15499a563c1aa6d6d57f@free.fr \
    --to=buildroot@buildroot.org \
    --cc=bb@ti.com \
    --cc=bernd@kuhls.net \
    --cc=heiko.thiery@gmail.com \
    --cc=ju.o@free.fr \
    --cc=michael@walle.cc \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox