Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Keep HOSTCFLAG and HOSTLDFLAGS consistent when Making Linux Kernel
Date: Thu, 17 Aug 2017 00:51:23 +0200	[thread overview]
Message-ID: <a2bbac58-b29b-cd95-ece4-1972bbafc971@mind.be> (raw)
In-Reply-To: <20170729150402.40d27236@windsurf.lan>



On 29-07-17 15:04, Thomas Petazzoni wrote:
> Unrelated to your patch, but this $(HOSTCFLAGS) thing is messy. We
> actually have:
> 
>  - HOSTCFLAGS, defined in the main Makefile to the value of
>    $(CFLAGS_FOR_BUILD), which is empty. HOSTCFLAGS is then exported. It
>    was done this way a long time ago in commit
>    c0d7d4e0355b49b489d7235e945481cf5d32087f (from 2007) for kconfig.
>    I'm not sure we still need this.
> 
>  - HOST_CFLAGS, defined in package/Makefile.in, which actually contains
>    some useful flags. It is most likely the one we should pass as
>    HOSTCFLAGS in LINUX_MAKE_FLAGS.

 In addition, I see no reason why we would *override* the kernel's HOSTCFLAGS.
So I think the proper fix is to do HOST_EXTRACFLAGS=$(HOST_CFLAGS) instead.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

      reply	other threads:[~2017-08-16 22:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 23:56 [Buildroot] [PATCH 1/1] Keep HOSTCFLAG and HOSTLDFLAGS consistent when Making Linux Kernel Jianming.qiao
2017-07-29 13:04 ` Thomas Petazzoni
2017-08-16 22:51   ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2bbac58-b29b-cd95-ece4-1972bbafc971@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox