Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/apparmor: fix per-package build with apache
Date: Wed, 17 Nov 2021 21:47:17 +0100	[thread overview]
Message-ID: <a8caa7e3-f449-ebd0-e94b-cff8163759f2@mind.be> (raw)
In-Reply-To: <20211117173152.994041-1-fontaine.fabrice@gmail.com>



On 17/11/2021 18:31, Fabrice Fontaine wrote:
> Fix the following per-package build failure with apache:
> 
> /home/buildroot/autobuild/instance-3/output-1/per-package/apparmor/host/aarch64-buildroot-linux-gnu/sysroot/usr/bin/../../usr/build-1/libtool --silent --mode=link /home/buildroot/autobuild/instance-3/output-1/per-package/apparmor/host/bin/aarch64-linux-gcc    -o mod_apparmor.la  -rpath /usr/modules -module -avoid-version    mod_apparmor.lo -L/home/buildroot/autobuild/instance-3/output-1/per-package/apparmor/host/bin/../aarch64-buildroot-linux-gnu/sysroot/usr/lib -lapparmor
> /home/buildroot/autobuild/instance-3/output-1/per-package/apache/host/opt/ext-toolchain/bin/../lib/gcc/aarch64-buildroot-linux-gnu/9.3.0/../../../../aarch64-buildroot-linux-gnu/bin/ld: cannot find /lib64/libc.so.6
> 
> This build failure is raised because the fix added by commit
> 3c836e54203b16015c9c52cbe007adc92d293a0d was incomplete as the apr
> special libtool script was not patched (see commit
> b747c29c4e8eb89b7b99658dfd34f4a6b6b0744d for a detailled explanation)
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/6747b1cb11b129ea4bcb1ecc9645e94fb8e095e8
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/apparmor/apparmor.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/apparmor/apparmor.mk b/package/apparmor/apparmor.mk
> index 400ea349ae..6f0e59224d 100644
> --- a/package/apparmor/apparmor.mk
> +++ b/package/apparmor/apparmor.mk
> @@ -59,7 +59,8 @@ ifeq ($(BR2_PER_PACKAGE_DIRECTORIES),y)
>   define APPARMOR_FIXUP_APXS
>   	$(SED) "s@$(PER_PACKAGE_DIR)/[^/]\+/@$(PER_PACKAGE_DIR)/apparmor/@g" \
>   		$(STAGING_DIR)/usr/bin/apxs \
> -		$(STAGING_DIR)/usr/build/config_vars.mk
> +		$(STAGING_DIR)/usr/build/config_vars.mk \
> +		$(STAGING_DIR)/usr/build-1/libtool

  I was surprised by the build-1, but it seems to be correct. Apache is weird...

  Now I said that: shouldn't all of this move to apache.mk, by adding them to 
APACHE_CONFIG_SCRIPTS? Of course, those are assumed to be in 
$(STAGING_DIR)/usr/bin, so you'd have to put ../build/config_vars.mk and I'm not 
sure if that won't break the realpath stuff...

  So anyway, applied to master, but it would be nice to do this in a cleaner way.

  Regards,
  Arnout

>   endef
>   APPARMOR_POST_CONFIGURE_HOOKS += APPARMOR_FIXUP_APXS
>   endif
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-11-17 20:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 17:31 [Buildroot] [PATCH 1/1] package/apparmor: fix per-package build with apache Fabrice Fontaine
2021-11-17 20:47 ` Arnout Vandecappelle [this message]
2021-11-18 18:13   ` Yann E. MORIN
2021-11-17 23:01 ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2020-09-01 20:10 Fabrice Fontaine
2020-09-05 12:50 ` Yann E. MORIN
2020-09-05 13:16   ` Thomas Petazzoni
2020-09-05 21:36     ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8caa7e3-f449-ebd0-e94b-cff8163759f2@mind.be \
    --to=arnout@mind.be \
    --cc=angelo.compagnucci@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox