Re: [Buildroot] [PATCH v2] package/linux-pam: bump to version 1.7.0

[Charlie Jenkins <charlie@rivosinc.com>]

On Mon, Apr 21, 2025 at 11:41:56PM +0200, Thomas Petazzoni wrote:
> Hello Charlie,
> 
> Thanks for this v2. Unfortunately, it still has some problems, see
> below.
> 
> On Wed, 02 Apr 2025 14:46:31 -0700
> Charlie Jenkins <charlie@rivosinc.com> wrote:
> 
> > diff --git a/package/linux-pam/Config.in b/package/linux-pam/Config.in
> > index 6b08a9c4c2a9ff14a9d43c96ecc99826c82bdae7..41de8f833b14247b85ce1849c08fac6a507727d5 100644
> > --- a/package/linux-pam/Config.in
> > +++ b/package/linux-pam/Config.in
> > @@ -3,6 +3,7 @@ config BR2_PACKAGE_LINUX_PAM
> >  	depends on BR2_ENABLE_LOCALE
> >  	depends on BR2_USE_WCHAR
> >  	depends on !BR2_STATIC_LIBS
> > +	depends on !BR2_microblaze # Toolchain doesn't support shared libraries
> 
> This is not true: Microblaze supports shared libraries.
> 
> Also, you cannot add a dependency like this: it would have to be
> propagated to all reverse dependencies of linux-pam:
> 
> package/nodm/Config.in: select BR2_PACKAGE_LINUX_PAM
> package/openvmtools/Config.in:  select BR2_PACKAGE_LINUX_PAM
> package/php-pam/Config.in:      select BR2_PACKAGE_LINUX_PAM
> package/refpolicy/Config.in:    select BR2_PACKAGE_LINUX_PAM if BR2_PACKAGE_OPENSSH \
> package/rsh-redone/Config.in:   select BR2_PACKAGE_LINUX_PAM
> package/rsh-redone/Config.in:   select BR2_PACKAGE_LINUX_PAM
> package/shadow/Config.in:       select BR2_PACKAGE_LINUX_PAM
> package/util-linux/Config.in:   select BR2_PACKAGE_LINUX_PAM
> package/util-linux/Config.in:   select BR2_PACKAGE_LINUX_PAM
> package/util-linux/Config.in:   select BR2_PACKAGE_LINUX_PAM
> package/util-linux/Config.in:   select BR2_PACKAGE_LINUX_PAM
> 
> And then in turn, propagated to the reverse dependencies of those
> reverse dependencies.
> 
> Bottom line: we really want to understand why it doesn't work on
> Microblaze, and chances are that the problem is not Microblaze
> specific. What issue are you trying to solve.

When trying to build on microblaze this is the error I get:

/scratch/filesystems/upstream_buildroot/build-microblaze/host/opt/ext-toolchain/bin/../lib/gcc/microblazeel-buildroot-linux-gnu/13.3.0/../../../../microblazeel-buildroot-linux-gnu/bin/ld:
FDE encoding in
/scratch/filesystems/upstream_buildroot/build-microblaze/host/opt/ext-toolchain/bin/../lib/gcc/microblazeel-buildroot-linux-gnu/13.3.0/libgcc.a(_umoddi3.o)(.eh_frame)
prevents .eh_frame_hdr table being created

I was unable to figure out the proper solution and found a couple of
sources that seemed to point to it being broken.

- Charlie

> 
> >  	depends on BR2_USE_MMU # fork()
> >  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
> >  	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
> > @@ -16,8 +17,10 @@ if BR2_PACKAGE_LINUX_PAM
> >  
> >  config BR2_PACKAGE_LINUX_PAM_LASTLOG
> >  	bool "pam_lastlog.so"
> > +	depends on !BR2_TOOLCHAIN_USES_MUSL
> 
> Why?
> 
> >  	help
> > -	  Build pam_lastlog.so module.
> > +	  Build pam_lastlog.so module. Requires toolchain support for shared libraries
> > +	  which microblaze does not have.
> 
> This does not make sense: the !BR2_microblaze dependency is on the main
> option, and you're adding this to the BR2_PACKAGE_LINUX_PAM_LASTLOG
> sub-option. Could you clarify?
> 
> Thanks!
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot