Re: [Buildroot] [PATCH 1/1] package/go: make pre-built compiler provide target support too

From: yann.morin@orange.com
To: Florian Larysch <fl@n621.de>
Cc: Romain Naour <romain.naour@smile.fr>, <buildroot@buildroot.org>,
	Christian Stewart <christian@aperture.us>,
	Thomas Perale <thomas.perale@mind.be>
Subject: Re: [Buildroot] [PATCH 1/1] package/go: make pre-built compiler provide target support too
Date: Thu, 10 Jul 2025 10:35:36 +0200	[thread overview]
Message-ID: <aG97WEwGhHgMN5p2@yd-6wlzhs3> (raw)
In-Reply-To: <20250709145921.wuzple2z7jrftmjh@n621.de>

Florian, All,

On 2025-07-09 16:59 +0200, Florian Larysch spake thusly:
> On Tue, Jul 08, 2025 at 07:04:22AM +0200, yann.morin@orange.com wrote:
> > So, I've had a go (aha!) at rewriting a commit log as I understood the
> > situation, building upon your initial commit log and trying to account
> > for Romain's comments:
> Thank you! That does seem more straightforward than the original
> message.
[--SNIP--]
> Either way, feel free to commit this with your reworded message. Or
> should I send a v2?

I think you should just resubmit with the updated commit log. Do not
forget to mention, below the '---' line, that is is a v2 that
incorporates an extended commit log, e.g. something like:

    Signed-off-by: Your NAME <your-email>
    Cc: romain <email>
    Cc: yann <email>
    ---
    Changes v1 -> v2:
    - rewrite commit log as suggested by Romain and Yann.

that way, it is easier for a future reviewer to follow what's going on.

Regards,
Yann E. MORIN.

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
|                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
| yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot